Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #68: share snapshot and restore db instance in other AWS accounts and regions #186

Merged
merged 28 commits into from
Nov 15, 2023

Conversation

namitad
Copy link
Collaborator

@namitad namitad commented Oct 29, 2023

Description

incremental PR to support sharing rds snapshot and restore db instance in other AWS accounts and regions.
This PR contains the following:

  1. lambda to execute SSM automation (existing one managed by AWS: AWSSupport-ShareRDSSnapshot) which shares rds snapshot to another account
  2. lambda to execute SSM automation (custom created) which executes restoration process for db instance in given account and region from the shared snapshot
  3. updates in template.yaml - cft for iam role for ssm execution, cft for ssm automation document for db restore, cfts for above 2 lambdas functions, updating state machine to include these steps in the pipeline.
  4. install.py updated to have s3 bucket as param since template.yaml size is greater than 51,200 bytes

Thanks for contributing this Pull Request. Make sure that you submit this Pull Request against the master branch of this repository, add a brief description, and tag the relevant issue(s) and PR(s) below.

  • Relevant Issues : (compulsory)
  • Relevant PRs : (optional)
  • Type of change :
    • New feature
    • Bug fix for existing feature
    • Code quality improvement
    • Addition or Improvement of tests
    • Addition or Improvement of documentation

@namitad namitad marked this pull request as ready for review October 30, 2023 06:42
@stationeros
Copy link
Contributor

Thank you for doing this , this has been a long wishlist item.

Can you put in some more details in the PR description to the functionality of the PR ? How many lambda functions? how does it facilitate backup and restore etc which will help me understand and better review this

Copy link
Contributor

@stationeros stationeros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass review comments

install.py Outdated Show resolved Hide resolved
src/common/python/constants.py Outdated Show resolved Hide resolved
src/restore/cross_account_db_restore.py Show resolved Hide resolved
template.yaml Show resolved Hide resolved
template.yaml Show resolved Hide resolved
template.yaml Show resolved Hide resolved
src/shareSnapshot/share_rds_snapshot_across_accounts.py Outdated Show resolved Hide resolved
template.yaml Outdated Show resolved Hide resolved
template.yaml Show resolved Hide resolved
@stationeros
Copy link
Contributor

Is there anything pending in this PR or we can merge this ?

@namitad
Copy link
Collaborator Author

namitad commented Nov 12, 2023

@stationeros i am facing issues in testing the state machine post merging latest changes. I have raised an issue for the same #198. will update on this thread post the fix and my testing and then this PR can be merged

@stationeros
Copy link
Contributor

Thank you namita , will check if these can be prevented by the CI pipeline

@namitad
Copy link
Collaborator Author

namitad commented Nov 15, 2023

@stationeros can we merge this PR? i will add some more incremental changes in follow up PRs

@stationeros stationeros merged commit 060cd71 into master Nov 15, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants