Skip to content

Commit

Permalink
Merge pull request #2226 from intuit/fix-maven-instructions
Browse files Browse the repository at this point in the history
Remove old references in maven instructions
  • Loading branch information
sugarmanz committed Jul 11, 2022
2 parents 91e0be2 + 169f878 commit a15f77b
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 7 deletions.
8 changes: 5 additions & 3 deletions plugins/maven/README.md
Expand Up @@ -107,14 +107,16 @@ You will need all the following configuration blocks for all parts of `auto` to
```xml
<scm>
<connection
>scm:git:https://${env.GH_USER}:${env.GH_TOKEN}@github.com/Fuego-Tools/java-test-project.git</connection>
>scm:git:https://${env.GH_USER}:${env.GH_TOKEN}@github.com/${owner}/${repo}.git</connection>
<developerConnection
>scm:git:https://${env.GH_USER}:${env.GH_TOKEN}@github.com/Fuego-Tools/java-test-project.git</developerConnection>
<url>https://github.com/Fuego-Tools/java-test-project</url>
>scm:git:https://${env.GH_USER}:${env.GH_TOKEN}@github.com/${owner}/${repo}.git</developerConnection>
<url>https://github.com/${owner}/${repo}</url>
<tag>HEAD</tag>
</scm>
```

> :warning: Either replace `${owner}/${repo}` with the corresponding GitHub owner and repository for your project or ensure those are configured as properties within the `pom.xml`
3. Versions Maven Plugin **RECOMMENDED** (Optional)

```xml
Expand Down
8 changes: 4 additions & 4 deletions plugins/maven/__tests__/maven.test.ts
Expand Up @@ -147,8 +147,8 @@ describe("maven", () => {
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
<scm>
<connection>scm:git:https://github.com/Fuego-Tools/java-test-project.git</connection>
<url>https://github.com/Fuego-Tools/java-test-project</url>
<connection>scm:git:https://github.com/intuit/auto.git</connection>
<url>https://github.com/intuit/auto</url>
<tag>HEAD</tag>
</scm>
</project>
Expand All @@ -158,8 +158,8 @@ describe("maven", () => {

expect(await hooks.getRepository.promise()).toStrictEqual(
expect.objectContaining({
owner: "Fuego-Tools",
repo: "java-test-project",
owner: "intuit",
repo: "auto",
})
);
});
Expand Down

0 comments on commit a15f77b

Please sign in to comment.