Merge pull request #1620 from intuit/series

make version, afterVersion, publish, and afterPublish series hooks
intuit · Oct 30, 2020 · b5edf26 · b5edf26
2 parents a928e85 + cf97afa
commit b5edf26
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/packages/core/src/auto.ts b/packages/core/src/auto.ts
@@ -228,7 +228,7 @@ export interface IAutoHooks {
     ]
   >;
   /** Version the package. This is a good opportunity to `git tag` the release also.  */
-  version: AsyncParallelHook<
+  version: AsyncSeriesHook<
     [
       DryRunOption &
         QuietOption & {
@@ -238,9 +238,9 @@ export interface IAutoHooks {
     ]
   >;
   /** Ran after the package has been versioned. */
-  afterVersion: AsyncParallelHook<[DryRunOption]>;
+  afterVersion: AsyncSeriesHook<[DryRunOption]>;
   /** Publish the package to some package distributor. You must push the tags to github! */
-  publish: AsyncParallelHook<
+  publish: AsyncSeriesHook<
     [
       {
         /** The semver bump that was applied in the version hook */
@@ -279,7 +279,7 @@ export interface IAutoHooks {
    */
   next: AsyncSeriesWaterfallHook<[string[], NextContext]>;
   /** Ran after the package has been published. */
-  afterPublish: AsyncParallelHook<[]>;
+  afterPublish: AsyncSeriesHook<[]>;
   /** Ran after the package has been published. */
   prCheck: AsyncSeriesHook<
     [

diff --git a/packages/core/src/utils/make-hooks.ts b/packages/core/src/utils/make-hooks.ts
@@ -30,10 +30,10 @@ export const makeHooks = (): IAutoHooks => ({
   getPreviousVersion: new AsyncSeriesBailHook(),
   getRepository: new AsyncSeriesBailHook(),
   prCheck: new AsyncSeriesBailHook(["prInformation"]),
-  version: new AsyncParallelHook(["version"]),
-  afterVersion: new AsyncParallelHook(["context"]),
-  publish: new AsyncParallelHook(["version"]),
-  afterPublish: new AsyncParallelHook(),
+  version: new AsyncSeriesHook(["version"]),
+  afterVersion: new AsyncSeriesHook(["context"]),
+  publish: new AsyncSeriesHook(["version"]),
+  afterPublish: new AsyncSeriesHook(),
   canary: new AsyncSeriesBailHook(["canaryContext"]),
   next: new AsyncSeriesWaterfallHook(["preReleaseVersions", "context"]),
 });