Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Git Config is manipulated outside of auto shipit #124

Closed
orta opened this issue Jan 3, 2019 · 1 comment · Fixed by #125
Closed

Git Config is manipulated outside of auto shipit #124

orta opened this issue Jan 3, 2019 · 1 comment · Fixed by #125
Labels
bug Something isn't working

Comments

@orta
Copy link
Contributor

orta commented Jan 3, 2019

Describe the bug

If you run yarn auto xxx - then your local git config is manipulated. It should probably only happen in yarn auto shipit and its substeps when deploying

To Reproduce

See the commits in #123, omakase-js/omakase@ccddab8 and artsy/reaction#1779

Expected behavior

Not editing local setup
@orta orta added the bug Something isn't working label Jan 3, 2019
@adierkens
Copy link
Collaborator

Comes from https://github.com/intuit/auto-release/blob/master/src/main.ts#L95

@hipstersmoothie hipstersmoothie mentioned this issue Jan 3, 2019
Merged
3 tasks
@hipstersmoothie hipstersmoothie mentioned this issue Jan 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

only set git user if one isn't already set hipstersmoothie/auto-release
2 participants
@orta @adierkens