Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better error message for no NPM_token in CI #1878

Merged
merged 2 commits into from
Mar 15, 2021
Merged

Conversation

hipstersmoothie
Copy link
Collaborator

@hipstersmoothie hipstersmoothie commented Mar 14, 2021

What Changed

npm will exit with a 0 when there is a npmrc error. this makes it so auto will error for this and provide a nice error message

Change Type

Indicate the type of change your pull request is:

  • documentation
  • patch
  • minor
  • major

🐤 Download canary assets:

auto-linux--canary.1878.23133.gz
auto-macos--canary.1878.23133.gz
auto-win.exe--canary.1878.23133.gz

📦 Published PR as canary version: under canary scope @auto-canary@10.20.3--canary.1878.23133.0

✨ Test out this PR locally via:

npm install @auto-canary/bot-list@10.20.3--canary.1878.23133.0
npm install @auto-canary/auto@10.20.3--canary.1878.23133.0
npm install @auto-canary/core@10.20.3--canary.1878.23133.0
npm install @auto-canary/package-json-utils@10.20.3--canary.1878.23133.0
npm install @auto-canary/all-contributors@10.20.3--canary.1878.23133.0
npm install @auto-canary/brew@10.20.3--canary.1878.23133.0
npm install @auto-canary/chrome@10.20.3--canary.1878.23133.0
npm install @auto-canary/cocoapods@10.20.3--canary.1878.23133.0
npm install @auto-canary/conventional-commits@10.20.3--canary.1878.23133.0
npm install @auto-canary/crates@10.20.3--canary.1878.23133.0
npm install @auto-canary/docker@10.20.3--canary.1878.23133.0
npm install @auto-canary/exec@10.20.3--canary.1878.23133.0
npm install @auto-canary/first-time-contributor@10.20.3--canary.1878.23133.0
npm install @auto-canary/gem@10.20.3--canary.1878.23133.0
npm install @auto-canary/gh-pages@10.20.3--canary.1878.23133.0
npm install @auto-canary/git-tag@10.20.3--canary.1878.23133.0
npm install @auto-canary/gradle@10.20.3--canary.1878.23133.0
npm install @auto-canary/jira@10.20.3--canary.1878.23133.0
npm install @auto-canary/magic-zero@10.20.3--canary.1878.23133.0
npm install @auto-canary/maven@10.20.3--canary.1878.23133.0
npm install @auto-canary/microsoft-teams@10.20.3--canary.1878.23133.0
npm install @auto-canary/npm@10.20.3--canary.1878.23133.0
npm install @auto-canary/omit-commits@10.20.3--canary.1878.23133.0
npm install @auto-canary/omit-release-notes@10.20.3--canary.1878.23133.0
npm install @auto-canary/pr-body-labels@10.20.3--canary.1878.23133.0
npm install @auto-canary/released@10.20.3--canary.1878.23133.0
npm install @auto-canary/s3@10.20.3--canary.1878.23133.0
npm install @auto-canary/slack@10.20.3--canary.1878.23133.0
npm install @auto-canary/twitter@10.20.3--canary.1878.23133.0
npm install @auto-canary/upload-assets@10.20.3--canary.1878.23133.0
npm install @auto-canary/vscode@10.20.3--canary.1878.23133.0
# or 
yarn add @auto-canary/bot-list@10.20.3--canary.1878.23133.0
yarn add @auto-canary/auto@10.20.3--canary.1878.23133.0
yarn add @auto-canary/core@10.20.3--canary.1878.23133.0
yarn add @auto-canary/package-json-utils@10.20.3--canary.1878.23133.0
yarn add @auto-canary/all-contributors@10.20.3--canary.1878.23133.0
yarn add @auto-canary/brew@10.20.3--canary.1878.23133.0
yarn add @auto-canary/chrome@10.20.3--canary.1878.23133.0
yarn add @auto-canary/cocoapods@10.20.3--canary.1878.23133.0
yarn add @auto-canary/conventional-commits@10.20.3--canary.1878.23133.0
yarn add @auto-canary/crates@10.20.3--canary.1878.23133.0
yarn add @auto-canary/docker@10.20.3--canary.1878.23133.0
yarn add @auto-canary/exec@10.20.3--canary.1878.23133.0
yarn add @auto-canary/first-time-contributor@10.20.3--canary.1878.23133.0
yarn add @auto-canary/gem@10.20.3--canary.1878.23133.0
yarn add @auto-canary/gh-pages@10.20.3--canary.1878.23133.0
yarn add @auto-canary/git-tag@10.20.3--canary.1878.23133.0
yarn add @auto-canary/gradle@10.20.3--canary.1878.23133.0
yarn add @auto-canary/jira@10.20.3--canary.1878.23133.0
yarn add @auto-canary/magic-zero@10.20.3--canary.1878.23133.0
yarn add @auto-canary/maven@10.20.3--canary.1878.23133.0
yarn add @auto-canary/microsoft-teams@10.20.3--canary.1878.23133.0
yarn add @auto-canary/npm@10.20.3--canary.1878.23133.0
yarn add @auto-canary/omit-commits@10.20.3--canary.1878.23133.0
yarn add @auto-canary/omit-release-notes@10.20.3--canary.1878.23133.0
yarn add @auto-canary/pr-body-labels@10.20.3--canary.1878.23133.0
yarn add @auto-canary/released@10.20.3--canary.1878.23133.0
yarn add @auto-canary/s3@10.20.3--canary.1878.23133.0
yarn add @auto-canary/slack@10.20.3--canary.1878.23133.0
yarn add @auto-canary/twitter@10.20.3--canary.1878.23133.0
yarn add @auto-canary/upload-assets@10.20.3--canary.1878.23133.0
yarn add @auto-canary/vscode@10.20.3--canary.1878.23133.0

@adierkens adierkens added the patch Increment the patch version when merged label Mar 14, 2021
@codecov
Copy link

codecov bot commented Mar 14, 2021

Codecov Report

Merging #1878 (614945d) into main (be5c068) will decrease coverage by 0.09%.
The diff coverage is 57.89%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1878      +/-   ##
==========================================
- Coverage   80.17%   80.07%   -0.10%     
==========================================
  Files          65       65              
  Lines        5164     5179      +15     
  Branches     1209     1213       +4     
==========================================
+ Hits         4140     4147       +7     
- Misses        688      695       +7     
- Partials      336      337       +1     
Impacted Files Coverage Δ
packages/core/src/utils/exec-promise.ts 72.09% <40.00%> (-4.84%) ⬇️
plugins/npm/src/index.ts 72.98% <64.28%> (-0.38%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be5c068...614945d. Read the comment docs.

@hipstersmoothie hipstersmoothie merged commit 26354a7 into main Mar 15, 2021
@hipstersmoothie hipstersmoothie deleted the npm-token-errors branch March 15, 2021 17:41
@adierkens
Copy link
Collaborator

🚀 PR was released in v10.20.3 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants