Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All contributors bug #1070

Merged
merged 4 commits into from
Mar 19, 2020
Merged

All contributors bug #1070

merged 4 commits into from
Mar 19, 2020

Conversation

hipstersmoothie
Copy link
Collaborator

@hipstersmoothie hipstersmoothie commented Mar 19, 2020

What Changed

  • handle root package just like sub-packages
  • fix bug where sub-commit authors weren't included

Why

fixed #1069

Todo:

  • Add tests
📦 Published PR as canary version: under canary scope @auto-canary@9.20.1-canary.1070.14061.0

✨ Test out this PR locally via:

npm install @auto-canary/bot-list@9.20.1-canary.1070.14061.0
npm install @auto-canary/auto@9.20.1-canary.1070.14061.0
npm install @auto-canary/core@9.20.1-canary.1070.14061.0
npm install @auto-canary/all-contributors@9.20.1-canary.1070.14061.0
npm install @auto-canary/chrome@9.20.1-canary.1070.14061.0
npm install @auto-canary/cocoapods@9.20.1-canary.1070.14061.0
npm install @auto-canary/conventional-commits@9.20.1-canary.1070.14061.0
npm install @auto-canary/crates@9.20.1-canary.1070.14061.0
npm install @auto-canary/exec@9.20.1-canary.1070.14061.0
npm install @auto-canary/first-time-contributor@9.20.1-canary.1070.14061.0
npm install @auto-canary/gh-pages@9.20.1-canary.1070.14061.0
npm install @auto-canary/git-tag@9.20.1-canary.1070.14061.0
npm install @auto-canary/gradle@9.20.1-canary.1070.14061.0
npm install @auto-canary/jira@9.20.1-canary.1070.14061.0
npm install @auto-canary/maven@9.20.1-canary.1070.14061.0
npm install @auto-canary/npm@9.20.1-canary.1070.14061.0
npm install @auto-canary/omit-commits@9.20.1-canary.1070.14061.0
npm install @auto-canary/omit-release-notes@9.20.1-canary.1070.14061.0
npm install @auto-canary/released@9.20.1-canary.1070.14061.0
npm install @auto-canary/s3@9.20.1-canary.1070.14061.0
npm install @auto-canary/slack@9.20.1-canary.1070.14061.0
npm install @auto-canary/twitter@9.20.1-canary.1070.14061.0
npm install @auto-canary/upload-assets@9.20.1-canary.1070.14061.0
# or 
yarn add @auto-canary/bot-list@9.20.1-canary.1070.14061.0
yarn add @auto-canary/auto@9.20.1-canary.1070.14061.0
yarn add @auto-canary/core@9.20.1-canary.1070.14061.0
yarn add @auto-canary/all-contributors@9.20.1-canary.1070.14061.0
yarn add @auto-canary/chrome@9.20.1-canary.1070.14061.0
yarn add @auto-canary/cocoapods@9.20.1-canary.1070.14061.0
yarn add @auto-canary/conventional-commits@9.20.1-canary.1070.14061.0
yarn add @auto-canary/crates@9.20.1-canary.1070.14061.0
yarn add @auto-canary/exec@9.20.1-canary.1070.14061.0
yarn add @auto-canary/first-time-contributor@9.20.1-canary.1070.14061.0
yarn add @auto-canary/gh-pages@9.20.1-canary.1070.14061.0
yarn add @auto-canary/git-tag@9.20.1-canary.1070.14061.0
yarn add @auto-canary/gradle@9.20.1-canary.1070.14061.0
yarn add @auto-canary/jira@9.20.1-canary.1070.14061.0
yarn add @auto-canary/maven@9.20.1-canary.1070.14061.0
yarn add @auto-canary/npm@9.20.1-canary.1070.14061.0
yarn add @auto-canary/omit-commits@9.20.1-canary.1070.14061.0
yarn add @auto-canary/omit-release-notes@9.20.1-canary.1070.14061.0
yarn add @auto-canary/released@9.20.1-canary.1070.14061.0
yarn add @auto-canary/s3@9.20.1-canary.1070.14061.0
yarn add @auto-canary/slack@9.20.1-canary.1070.14061.0
yarn add @auto-canary/twitter@9.20.1-canary.1070.14061.0
yarn add @auto-canary/upload-assets@9.20.1-canary.1070.14061.0

@hipstersmoothie hipstersmoothie added the patch Increment the patch version when merged label Mar 19, 2020
@codecov
Copy link

codecov bot commented Mar 19, 2020

Codecov Report

Merging #1070 into master will increase coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1070      +/-   ##
==========================================
+ Coverage   81.41%   81.51%   +0.09%     
==========================================
  Files          51       51              
  Lines        3622     3619       -3     
  Branches      765      724      -41     
==========================================
+ Hits         2949     2950       +1     
+ Misses        498      496       -2     
+ Partials      175      173       -2
Impacted Files Coverage Δ
plugins/all-contributors/src/index.ts 86.45% <100%> (+1.6%) ⬆️
packages/core/src/utils/get-current-branch.ts 75% <0%> (+16.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cc43c0...e1943fa. Read the comment docs.

@hipstersmoothie hipstersmoothie merged commit e3ad36f into master Mar 19, 2020
@hipstersmoothie hipstersmoothie deleted the all-contributors-bug branch March 19, 2020 21:07
@adierkens
Copy link
Collaborator

🚀 PR was released in v9.20.1 🚀

@adierkens adierkens added the released This issue/pull request has been released. label Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

All-contributors plugin missed a contributor
2 participants