Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Brew Plugin #1099

Merged
merged 3 commits into from
Apr 1, 2020
Merged

Add Brew Plugin #1099

merged 3 commits into from
Apr 1, 2020

Conversation

hipstersmoothie
Copy link
Collaborator

@hipstersmoothie hipstersmoothie commented Apr 1, 2020

What Changed

Generalize auto's custom brew plugin into an official reusable plugin πŸŽ‰

Why

closes #1098

Todo:

  • Add tests
  • Add docs
πŸ“¦ Published PR as canary version: under canary scope @auto-canary@9.23.0-canary.1099.14367.0

✨ Test out this PR locally via:

npm install @auto-canary/bot-list@9.23.0-canary.1099.14367.0
npm install @auto-canary/auto@9.23.0-canary.1099.14367.0
npm install @auto-canary/core@9.23.0-canary.1099.14367.0
npm install @auto-canary/all-contributors@9.23.0-canary.1099.14367.0
npm install @auto-canary/brew@9.23.0-canary.1099.14367.0
npm install @auto-canary/chrome@9.23.0-canary.1099.14367.0
npm install @auto-canary/cocoapods@9.23.0-canary.1099.14367.0
npm install @auto-canary/conventional-commits@9.23.0-canary.1099.14367.0
npm install @auto-canary/crates@9.23.0-canary.1099.14367.0
npm install @auto-canary/exec@9.23.0-canary.1099.14367.0
npm install @auto-canary/first-time-contributor@9.23.0-canary.1099.14367.0
npm install @auto-canary/gh-pages@9.23.0-canary.1099.14367.0
npm install @auto-canary/git-tag@9.23.0-canary.1099.14367.0
npm install @auto-canary/gradle@9.23.0-canary.1099.14367.0
npm install @auto-canary/jira@9.23.0-canary.1099.14367.0
npm install @auto-canary/maven@9.23.0-canary.1099.14367.0
npm install @auto-canary/npm@9.23.0-canary.1099.14367.0
npm install @auto-canary/omit-commits@9.23.0-canary.1099.14367.0
npm install @auto-canary/omit-release-notes@9.23.0-canary.1099.14367.0
npm install @auto-canary/released@9.23.0-canary.1099.14367.0
npm install @auto-canary/s3@9.23.0-canary.1099.14367.0
npm install @auto-canary/slack@9.23.0-canary.1099.14367.0
npm install @auto-canary/twitter@9.23.0-canary.1099.14367.0
npm install @auto-canary/upload-assets@9.23.0-canary.1099.14367.0
# or 
yarn add @auto-canary/bot-list@9.23.0-canary.1099.14367.0
yarn add @auto-canary/auto@9.23.0-canary.1099.14367.0
yarn add @auto-canary/core@9.23.0-canary.1099.14367.0
yarn add @auto-canary/all-contributors@9.23.0-canary.1099.14367.0
yarn add @auto-canary/brew@9.23.0-canary.1099.14367.0
yarn add @auto-canary/chrome@9.23.0-canary.1099.14367.0
yarn add @auto-canary/cocoapods@9.23.0-canary.1099.14367.0
yarn add @auto-canary/conventional-commits@9.23.0-canary.1099.14367.0
yarn add @auto-canary/crates@9.23.0-canary.1099.14367.0
yarn add @auto-canary/exec@9.23.0-canary.1099.14367.0
yarn add @auto-canary/first-time-contributor@9.23.0-canary.1099.14367.0
yarn add @auto-canary/gh-pages@9.23.0-canary.1099.14367.0
yarn add @auto-canary/git-tag@9.23.0-canary.1099.14367.0
yarn add @auto-canary/gradle@9.23.0-canary.1099.14367.0
yarn add @auto-canary/jira@9.23.0-canary.1099.14367.0
yarn add @auto-canary/maven@9.23.0-canary.1099.14367.0
yarn add @auto-canary/npm@9.23.0-canary.1099.14367.0
yarn add @auto-canary/omit-commits@9.23.0-canary.1099.14367.0
yarn add @auto-canary/omit-release-notes@9.23.0-canary.1099.14367.0
yarn add @auto-canary/released@9.23.0-canary.1099.14367.0
yarn add @auto-canary/s3@9.23.0-canary.1099.14367.0
yarn add @auto-canary/slack@9.23.0-canary.1099.14367.0
yarn add @auto-canary/twitter@9.23.0-canary.1099.14367.0
yarn add @auto-canary/upload-assets@9.23.0-canary.1099.14367.0

@hipstersmoothie hipstersmoothie added the minor Increment the minor version when merged label Apr 1, 2020
@codecov
Copy link

codecov bot commented Apr 1, 2020

Codecov Report

Merging #1099 into master will increase coverage by 0.18%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1099      +/-   ##
==========================================
+ Coverage   81.53%   81.72%   +0.18%     
==========================================
  Files          51       52       +1     
  Lines        3629     3666      +37     
  Branches      768      774       +6     
==========================================
+ Hits         2959     2996      +37     
  Misses        497      497              
  Partials      173      173
Impacted Files Coverage Ξ”
packages/core/src/validate-config.ts 92.92% <100%> (-0.07%) ⬇️
plugins/brew/src/index.ts 100% <100%> (ΓΈ)

Continue to review full report at Codecov.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update 328945f...b1def3f. Read the comment docs.

@hipstersmoothie hipstersmoothie merged commit 43ccb78 into master Apr 1, 2020
@hipstersmoothie hipstersmoothie deleted the brew branch April 1, 2020 22:04
@adierkens
Copy link
Collaborator

πŸš€ PR was released in v9.23.0 πŸš€

@adierkens adierkens added the released This issue/pull request has been released. label Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Increment the minor version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Brew Plugin
2 participants