Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs links #1336

Merged
merged 2 commits into from
Jun 30, 2020
Merged

Fix docs links #1336

merged 2 commits into from
Jun 30, 2020

Conversation

hipstersmoothie
Copy link
Collaborator

@hipstersmoothie hipstersmoothie commented Jun 30, 2020

What Changed

Links didn't work in new docs library

Why

closes #1335

📦 Published PR as canary version: under canary scope @auto-canary@9.40.6-canary.1336.16893.0

✨ Test out this PR locally via:

npm install @auto-canary/bot-list@9.40.6-canary.1336.16893.0
npm install @auto-canary/auto@9.40.6-canary.1336.16893.0
npm install @auto-canary/core@9.40.6-canary.1336.16893.0
npm install @auto-canary/all-contributors@9.40.6-canary.1336.16893.0
npm install @auto-canary/brew@9.40.6-canary.1336.16893.0
npm install @auto-canary/chrome@9.40.6-canary.1336.16893.0
npm install @auto-canary/cocoapods@9.40.6-canary.1336.16893.0
npm install @auto-canary/conventional-commits@9.40.6-canary.1336.16893.0
npm install @auto-canary/crates@9.40.6-canary.1336.16893.0
npm install @auto-canary/exec@9.40.6-canary.1336.16893.0
npm install @auto-canary/first-time-contributor@9.40.6-canary.1336.16893.0
npm install @auto-canary/gem@9.40.6-canary.1336.16893.0
npm install @auto-canary/gh-pages@9.40.6-canary.1336.16893.0
npm install @auto-canary/git-tag@9.40.6-canary.1336.16893.0
npm install @auto-canary/gradle@9.40.6-canary.1336.16893.0
npm install @auto-canary/jira@9.40.6-canary.1336.16893.0
npm install @auto-canary/maven@9.40.6-canary.1336.16893.0
npm install @auto-canary/npm@9.40.6-canary.1336.16893.0
npm install @auto-canary/omit-commits@9.40.6-canary.1336.16893.0
npm install @auto-canary/omit-release-notes@9.40.6-canary.1336.16893.0
npm install @auto-canary/released@9.40.6-canary.1336.16893.0
npm install @auto-canary/s3@9.40.6-canary.1336.16893.0
npm install @auto-canary/slack@9.40.6-canary.1336.16893.0
npm install @auto-canary/twitter@9.40.6-canary.1336.16893.0
npm install @auto-canary/upload-assets@9.40.6-canary.1336.16893.0
# or 
yarn add @auto-canary/bot-list@9.40.6-canary.1336.16893.0
yarn add @auto-canary/auto@9.40.6-canary.1336.16893.0
yarn add @auto-canary/core@9.40.6-canary.1336.16893.0
yarn add @auto-canary/all-contributors@9.40.6-canary.1336.16893.0
yarn add @auto-canary/brew@9.40.6-canary.1336.16893.0
yarn add @auto-canary/chrome@9.40.6-canary.1336.16893.0
yarn add @auto-canary/cocoapods@9.40.6-canary.1336.16893.0
yarn add @auto-canary/conventional-commits@9.40.6-canary.1336.16893.0
yarn add @auto-canary/crates@9.40.6-canary.1336.16893.0
yarn add @auto-canary/exec@9.40.6-canary.1336.16893.0
yarn add @auto-canary/first-time-contributor@9.40.6-canary.1336.16893.0
yarn add @auto-canary/gem@9.40.6-canary.1336.16893.0
yarn add @auto-canary/gh-pages@9.40.6-canary.1336.16893.0
yarn add @auto-canary/git-tag@9.40.6-canary.1336.16893.0
yarn add @auto-canary/gradle@9.40.6-canary.1336.16893.0
yarn add @auto-canary/jira@9.40.6-canary.1336.16893.0
yarn add @auto-canary/maven@9.40.6-canary.1336.16893.0
yarn add @auto-canary/npm@9.40.6-canary.1336.16893.0
yarn add @auto-canary/omit-commits@9.40.6-canary.1336.16893.0
yarn add @auto-canary/omit-release-notes@9.40.6-canary.1336.16893.0
yarn add @auto-canary/released@9.40.6-canary.1336.16893.0
yarn add @auto-canary/s3@9.40.6-canary.1336.16893.0
yarn add @auto-canary/slack@9.40.6-canary.1336.16893.0
yarn add @auto-canary/twitter@9.40.6-canary.1336.16893.0
yarn add @auto-canary/upload-assets@9.40.6-canary.1336.16893.0

@hipstersmoothie hipstersmoothie added the documentation Changes only affect the documentation label Jun 30, 2020
@codecov
Copy link

codecov bot commented Jun 30, 2020

Codecov Report

Merging #1336 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1336   +/-   ##
=======================================
  Coverage   81.02%   81.02%           
=======================================
  Files          56       56           
  Lines        4158     4158           
  Branches      908      864   -44     
=======================================
  Hits         3369     3369           
  Misses        553      553           
  Partials      236      236           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00deab9...f82054c. Read the comment docs.

@hipstersmoothie hipstersmoothie merged commit da3275d into master Jun 30, 2020
@hipstersmoothie hipstersmoothie deleted the links branch June 30, 2020 17:12
@adierkens
Copy link
Collaborator

🚀 PR was released in v9.40.6 🚀

@adierkens adierkens added the released This issue/pull request has been released. label Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Changes only affect the documentation released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs links do not work
2 participants