Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attempt to construct the GitHub graphql root API endpoint if githubApi is provided #1349

Merged
merged 2 commits into from Jul 6, 2020

Conversation

hipstersmoothie
Copy link
Collaborator

@hipstersmoothie hipstersmoothie commented Jul 6, 2020

What Changed

If a githubApi URL is provided it is probably enterprise so we try to construct the URL

Why

attempt to fix #1340

Todo:

  • Add tests
  • Update docs
📦 Published PR as canary version: under canary scope @auto-canary@9.40.7-canary.1349.17053.0

✨ Test out this PR locally via:

npm install @auto-canary/bot-list@9.40.7-canary.1349.17053.0
npm install @auto-canary/auto@9.40.7-canary.1349.17053.0
npm install @auto-canary/core@9.40.7-canary.1349.17053.0
npm install @auto-canary/all-contributors@9.40.7-canary.1349.17053.0
npm install @auto-canary/brew@9.40.7-canary.1349.17053.0
npm install @auto-canary/chrome@9.40.7-canary.1349.17053.0
npm install @auto-canary/cocoapods@9.40.7-canary.1349.17053.0
npm install @auto-canary/conventional-commits@9.40.7-canary.1349.17053.0
npm install @auto-canary/crates@9.40.7-canary.1349.17053.0
npm install @auto-canary/exec@9.40.7-canary.1349.17053.0
npm install @auto-canary/first-time-contributor@9.40.7-canary.1349.17053.0
npm install @auto-canary/gem@9.40.7-canary.1349.17053.0
npm install @auto-canary/gh-pages@9.40.7-canary.1349.17053.0
npm install @auto-canary/git-tag@9.40.7-canary.1349.17053.0
npm install @auto-canary/gradle@9.40.7-canary.1349.17053.0
npm install @auto-canary/jira@9.40.7-canary.1349.17053.0
npm install @auto-canary/maven@9.40.7-canary.1349.17053.0
npm install @auto-canary/npm@9.40.7-canary.1349.17053.0
npm install @auto-canary/omit-commits@9.40.7-canary.1349.17053.0
npm install @auto-canary/omit-release-notes@9.40.7-canary.1349.17053.0
npm install @auto-canary/released@9.40.7-canary.1349.17053.0
npm install @auto-canary/s3@9.40.7-canary.1349.17053.0
npm install @auto-canary/slack@9.40.7-canary.1349.17053.0
npm install @auto-canary/twitter@9.40.7-canary.1349.17053.0
npm install @auto-canary/upload-assets@9.40.7-canary.1349.17053.0
# or 
yarn add @auto-canary/bot-list@9.40.7-canary.1349.17053.0
yarn add @auto-canary/auto@9.40.7-canary.1349.17053.0
yarn add @auto-canary/core@9.40.7-canary.1349.17053.0
yarn add @auto-canary/all-contributors@9.40.7-canary.1349.17053.0
yarn add @auto-canary/brew@9.40.7-canary.1349.17053.0
yarn add @auto-canary/chrome@9.40.7-canary.1349.17053.0
yarn add @auto-canary/cocoapods@9.40.7-canary.1349.17053.0
yarn add @auto-canary/conventional-commits@9.40.7-canary.1349.17053.0
yarn add @auto-canary/crates@9.40.7-canary.1349.17053.0
yarn add @auto-canary/exec@9.40.7-canary.1349.17053.0
yarn add @auto-canary/first-time-contributor@9.40.7-canary.1349.17053.0
yarn add @auto-canary/gem@9.40.7-canary.1349.17053.0
yarn add @auto-canary/gh-pages@9.40.7-canary.1349.17053.0
yarn add @auto-canary/git-tag@9.40.7-canary.1349.17053.0
yarn add @auto-canary/gradle@9.40.7-canary.1349.17053.0
yarn add @auto-canary/jira@9.40.7-canary.1349.17053.0
yarn add @auto-canary/maven@9.40.7-canary.1349.17053.0
yarn add @auto-canary/npm@9.40.7-canary.1349.17053.0
yarn add @auto-canary/omit-commits@9.40.7-canary.1349.17053.0
yarn add @auto-canary/omit-release-notes@9.40.7-canary.1349.17053.0
yarn add @auto-canary/released@9.40.7-canary.1349.17053.0
yarn add @auto-canary/s3@9.40.7-canary.1349.17053.0
yarn add @auto-canary/slack@9.40.7-canary.1349.17053.0
yarn add @auto-canary/twitter@9.40.7-canary.1349.17053.0
yarn add @auto-canary/upload-assets@9.40.7-canary.1349.17053.0

@hipstersmoothie hipstersmoothie added the patch Increment the patch version when merged label Jul 6, 2020
@codecov
Copy link

codecov bot commented Jul 6, 2020

Codecov Report

Merging #1349 into master will not change coverage.
The diff coverage is 75.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1349   +/-   ##
=======================================
  Coverage   81.02%   81.02%           
=======================================
  Files          56       56           
  Lines        4158     4158           
  Branches      908      906    -2     
=======================================
  Hits         3369     3369           
  Misses        553      553           
  Partials      236      236           
Impacted Files Coverage Δ
packages/core/src/auto.ts 77.37% <ø> (-0.06%) ⬇️
packages/core/src/git.ts 89.04% <75.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81ee164...2f08d26. Read the comment docs.

@hipstersmoothie hipstersmoothie merged commit 86a0687 into master Jul 6, 2020
@hipstersmoothie hipstersmoothie deleted the docsearch branch July 6, 2020 22:27
@adierkens
Copy link
Collaborator

🚀 PR was released in v9.41.1 🚀

@adierkens adierkens added the released This issue/pull request has been released. label Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

404 error with auto shipit even with GHE god mode token 😖
2 participants