Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

catch errors when finding tags on next #1402

Merged
merged 1 commit into from
Jul 28, 2020
Merged

Conversation

hipstersmoothie
Copy link
Collaborator

@hipstersmoothie hipstersmoothie commented Jul 27, 2020

What Changed

Add error handling when getting tags

Why

closes #1401

Todo:

  • Add tests
📦 Published PR as canary version: under canary scope @auto-canary@9.48.2-canary.1402.17571.0

✨ Test out this PR locally via:

npm install @auto-canary/bot-list@9.48.2-canary.1402.17571.0
npm install @auto-canary/auto@9.48.2-canary.1402.17571.0
npm install @auto-canary/core@9.48.2-canary.1402.17571.0
npm install @auto-canary/all-contributors@9.48.2-canary.1402.17571.0
npm install @auto-canary/brew@9.48.2-canary.1402.17571.0
npm install @auto-canary/chrome@9.48.2-canary.1402.17571.0
npm install @auto-canary/cocoapods@9.48.2-canary.1402.17571.0
npm install @auto-canary/conventional-commits@9.48.2-canary.1402.17571.0
npm install @auto-canary/crates@9.48.2-canary.1402.17571.0
npm install @auto-canary/exec@9.48.2-canary.1402.17571.0
npm install @auto-canary/first-time-contributor@9.48.2-canary.1402.17571.0
npm install @auto-canary/gem@9.48.2-canary.1402.17571.0
npm install @auto-canary/gh-pages@9.48.2-canary.1402.17571.0
npm install @auto-canary/git-tag@9.48.2-canary.1402.17571.0
npm install @auto-canary/gradle@9.48.2-canary.1402.17571.0
npm install @auto-canary/jira@9.48.2-canary.1402.17571.0
npm install @auto-canary/maven@9.48.2-canary.1402.17571.0
npm install @auto-canary/npm@9.48.2-canary.1402.17571.0
npm install @auto-canary/omit-commits@9.48.2-canary.1402.17571.0
npm install @auto-canary/omit-release-notes@9.48.2-canary.1402.17571.0
npm install @auto-canary/released@9.48.2-canary.1402.17571.0
npm install @auto-canary/s3@9.48.2-canary.1402.17571.0
npm install @auto-canary/slack@9.48.2-canary.1402.17571.0
npm install @auto-canary/twitter@9.48.2-canary.1402.17571.0
npm install @auto-canary/upload-assets@9.48.2-canary.1402.17571.0
# or 
yarn add @auto-canary/bot-list@9.48.2-canary.1402.17571.0
yarn add @auto-canary/auto@9.48.2-canary.1402.17571.0
yarn add @auto-canary/core@9.48.2-canary.1402.17571.0
yarn add @auto-canary/all-contributors@9.48.2-canary.1402.17571.0
yarn add @auto-canary/brew@9.48.2-canary.1402.17571.0
yarn add @auto-canary/chrome@9.48.2-canary.1402.17571.0
yarn add @auto-canary/cocoapods@9.48.2-canary.1402.17571.0
yarn add @auto-canary/conventional-commits@9.48.2-canary.1402.17571.0
yarn add @auto-canary/crates@9.48.2-canary.1402.17571.0
yarn add @auto-canary/exec@9.48.2-canary.1402.17571.0
yarn add @auto-canary/first-time-contributor@9.48.2-canary.1402.17571.0
yarn add @auto-canary/gem@9.48.2-canary.1402.17571.0
yarn add @auto-canary/gh-pages@9.48.2-canary.1402.17571.0
yarn add @auto-canary/git-tag@9.48.2-canary.1402.17571.0
yarn add @auto-canary/gradle@9.48.2-canary.1402.17571.0
yarn add @auto-canary/jira@9.48.2-canary.1402.17571.0
yarn add @auto-canary/maven@9.48.2-canary.1402.17571.0
yarn add @auto-canary/npm@9.48.2-canary.1402.17571.0
yarn add @auto-canary/omit-commits@9.48.2-canary.1402.17571.0
yarn add @auto-canary/omit-release-notes@9.48.2-canary.1402.17571.0
yarn add @auto-canary/released@9.48.2-canary.1402.17571.0
yarn add @auto-canary/s3@9.48.2-canary.1402.17571.0
yarn add @auto-canary/slack@9.48.2-canary.1402.17571.0
yarn add @auto-canary/twitter@9.48.2-canary.1402.17571.0
yarn add @auto-canary/upload-assets@9.48.2-canary.1402.17571.0

@hipstersmoothie hipstersmoothie added the patch Increment the patch version when merged label Jul 27, 2020
@codecov
Copy link

codecov bot commented Jul 27, 2020

Codecov Report

Merging #1402 into master will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1402      +/-   ##
==========================================
+ Coverage   81.02%   81.06%   +0.03%     
==========================================
  Files          56       56              
  Lines        4222     4224       +2     
  Branches      929      882      -47     
==========================================
+ Hits         3421     3424       +3     
  Misses        561      561              
+ Partials      240      239       -1     
Impacted Files Coverage Δ
packages/core/src/auto.ts 77.62% <100.00%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6818c52...4496a0e. Read the comment docs.

@hipstersmoothie hipstersmoothie merged commit 9e933c3 into master Jul 28, 2020
@hipstersmoothie hipstersmoothie deleted the next-no-tags branch July 28, 2020 15:25
@adierkens
Copy link
Collaborator

🚀 PR was released in v9.48.2 🚀

@adierkens adierkens added the released This issue/pull request has been released. label Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
2 participants