Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add helpful error message when git state isn't clean for gh-pages plugin #1410

Merged
merged 2 commits into from
Jul 28, 2020

Conversation

hipstersmoothie
Copy link
Collaborator

@hipstersmoothie hipstersmoothie commented Jul 28, 2020

📦 Published PR as canary version: under canary scope @auto-canary@9.48.2-canary.1410.17646.0

✨ Test out this PR locally via:

npm install @auto-canary/bot-list@9.48.2-canary.1410.17646.0
npm install @auto-canary/auto@9.48.2-canary.1410.17646.0
npm install @auto-canary/core@9.48.2-canary.1410.17646.0
npm install @auto-canary/all-contributors@9.48.2-canary.1410.17646.0
npm install @auto-canary/brew@9.48.2-canary.1410.17646.0
npm install @auto-canary/chrome@9.48.2-canary.1410.17646.0
npm install @auto-canary/cocoapods@9.48.2-canary.1410.17646.0
npm install @auto-canary/conventional-commits@9.48.2-canary.1410.17646.0
npm install @auto-canary/crates@9.48.2-canary.1410.17646.0
npm install @auto-canary/exec@9.48.2-canary.1410.17646.0
npm install @auto-canary/first-time-contributor@9.48.2-canary.1410.17646.0
npm install @auto-canary/gem@9.48.2-canary.1410.17646.0
npm install @auto-canary/gh-pages@9.48.2-canary.1410.17646.0
npm install @auto-canary/git-tag@9.48.2-canary.1410.17646.0
npm install @auto-canary/gradle@9.48.2-canary.1410.17646.0
npm install @auto-canary/jira@9.48.2-canary.1410.17646.0
npm install @auto-canary/maven@9.48.2-canary.1410.17646.0
npm install @auto-canary/npm@9.48.2-canary.1410.17646.0
npm install @auto-canary/omit-commits@9.48.2-canary.1410.17646.0
npm install @auto-canary/omit-release-notes@9.48.2-canary.1410.17646.0
npm install @auto-canary/released@9.48.2-canary.1410.17646.0
npm install @auto-canary/s3@9.48.2-canary.1410.17646.0
npm install @auto-canary/slack@9.48.2-canary.1410.17646.0
npm install @auto-canary/twitter@9.48.2-canary.1410.17646.0
npm install @auto-canary/upload-assets@9.48.2-canary.1410.17646.0
# or 
yarn add @auto-canary/bot-list@9.48.2-canary.1410.17646.0
yarn add @auto-canary/auto@9.48.2-canary.1410.17646.0
yarn add @auto-canary/core@9.48.2-canary.1410.17646.0
yarn add @auto-canary/all-contributors@9.48.2-canary.1410.17646.0
yarn add @auto-canary/brew@9.48.2-canary.1410.17646.0
yarn add @auto-canary/chrome@9.48.2-canary.1410.17646.0
yarn add @auto-canary/cocoapods@9.48.2-canary.1410.17646.0
yarn add @auto-canary/conventional-commits@9.48.2-canary.1410.17646.0
yarn add @auto-canary/crates@9.48.2-canary.1410.17646.0
yarn add @auto-canary/exec@9.48.2-canary.1410.17646.0
yarn add @auto-canary/first-time-contributor@9.48.2-canary.1410.17646.0
yarn add @auto-canary/gem@9.48.2-canary.1410.17646.0
yarn add @auto-canary/gh-pages@9.48.2-canary.1410.17646.0
yarn add @auto-canary/git-tag@9.48.2-canary.1410.17646.0
yarn add @auto-canary/gradle@9.48.2-canary.1410.17646.0
yarn add @auto-canary/jira@9.48.2-canary.1410.17646.0
yarn add @auto-canary/maven@9.48.2-canary.1410.17646.0
yarn add @auto-canary/npm@9.48.2-canary.1410.17646.0
yarn add @auto-canary/omit-commits@9.48.2-canary.1410.17646.0
yarn add @auto-canary/omit-release-notes@9.48.2-canary.1410.17646.0
yarn add @auto-canary/released@9.48.2-canary.1410.17646.0
yarn add @auto-canary/s3@9.48.2-canary.1410.17646.0
yarn add @auto-canary/slack@9.48.2-canary.1410.17646.0
yarn add @auto-canary/twitter@9.48.2-canary.1410.17646.0
yarn add @auto-canary/upload-assets@9.48.2-canary.1410.17646.0

@hipstersmoothie hipstersmoothie added the patch Increment the patch version when merged label Jul 28, 2020
@codecov
Copy link

codecov bot commented Jul 28, 2020

Codecov Report

Merging #1410 into master will decrease coverage by 0.04%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1410      +/-   ##
==========================================
- Coverage   81.02%   80.98%   -0.05%     
==========================================
  Files          56       56              
  Lines        4222     4228       +6     
  Branches      929      884      -45     
==========================================
+ Hits         3421     3424       +3     
- Misses        561      564       +3     
  Partials      240      240              
Impacted Files Coverage Δ
plugins/gh-pages/src/index.ts 86.53% <50.00%> (-4.77%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6818c52...c5718ec. Read the comment docs.

@hipstersmoothie hipstersmoothie merged commit 33c2c94 into master Jul 28, 2020
@hipstersmoothie hipstersmoothie deleted the gh-pages-error branch July 28, 2020 16:10
@adierkens
Copy link
Collaborator

🚀 PR was released in v9.48.2 🚀

@adierkens adierkens added the released This issue/pull request has been released. label Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants