Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use GH_TOKEN if PRIVATE_TOKEN is not set #1446

Merged
merged 1 commit into from
Aug 7, 2020

Conversation

hborawski
Copy link
Collaborator

What Changed

sets PRIVATE_TOKEN to GH_TOKEN when calling to all-contributors-cli if it isn't already set

Why

all-contributors-cli uses PRIVATE_TOKEN for authentication, and auto uses GH_TOKEN, to ease use with auto, users shouldn't need to set two separate environment variables to the same value
Todo:

  • Add tests
  • Add docs

@hipstersmoothie hipstersmoothie added the minor Increment the minor version when merged label Aug 7, 2020
@codecov
Copy link

codecov bot commented Aug 7, 2020

Codecov Report

Merging #1446 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1446   +/-   ##
=======================================
  Coverage   80.78%   80.79%           
=======================================
  Files          58       58           
  Lines        4294     4296    +2     
  Branches      900      901    +1     
=======================================
+ Hits         3469     3471    +2     
  Misses        586      586           
  Partials      239      239           
Impacted Files Coverage Δ
plugins/all-contributors/src/index.ts 86.02% <100.00%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 514a114...965ff57. Read the comment docs.

@hipstersmoothie hipstersmoothie merged commit dcba1e9 into intuit:master Aug 7, 2020
@adierkens
Copy link
Collaborator

🚀 PR was released in v9.50.0 🚀

@adierkens adierkens added the released This issue/pull request has been released. label Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Increment the minor version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants