Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix default bump type #1470

Merged
merged 1 commit into from
Aug 14, 2020
Merged

fix default bump type #1470

merged 1 commit into from
Aug 14, 2020

Conversation

hipstersmoothie
Copy link
Collaborator

@hipstersmoothie hipstersmoothie commented Aug 14, 2020

What Changed

When the default bump was set to a none release version was still returning patch.

Why

closes #1469

📦 Published PR as canary version: under canary scope @auto-canary@9.50.7-canary.1470.18220.0

✨ Test out this PR locally via:

npm install @auto-canary/bot-list@9.50.7-canary.1470.18220.0
npm install @auto-canary/auto@9.50.7-canary.1470.18220.0
npm install @auto-canary/core@9.50.7-canary.1470.18220.0
npm install @auto-canary/all-contributors@9.50.7-canary.1470.18220.0
npm install @auto-canary/brew@9.50.7-canary.1470.18220.0
npm install @auto-canary/chrome@9.50.7-canary.1470.18220.0
npm install @auto-canary/cocoapods@9.50.7-canary.1470.18220.0
npm install @auto-canary/conventional-commits@9.50.7-canary.1470.18220.0
npm install @auto-canary/crates@9.50.7-canary.1470.18220.0
npm install @auto-canary/exec@9.50.7-canary.1470.18220.0
npm install @auto-canary/first-time-contributor@9.50.7-canary.1470.18220.0
npm install @auto-canary/gem@9.50.7-canary.1470.18220.0
npm install @auto-canary/gh-pages@9.50.7-canary.1470.18220.0
npm install @auto-canary/git-tag@9.50.7-canary.1470.18220.0
npm install @auto-canary/gradle@9.50.7-canary.1470.18220.0
npm install @auto-canary/jira@9.50.7-canary.1470.18220.0
npm install @auto-canary/maven@9.50.7-canary.1470.18220.0
npm install @auto-canary/npm@9.50.7-canary.1470.18220.0
npm install @auto-canary/omit-commits@9.50.7-canary.1470.18220.0
npm install @auto-canary/omit-release-notes@9.50.7-canary.1470.18220.0
npm install @auto-canary/released@9.50.7-canary.1470.18220.0
npm install @auto-canary/s3@9.50.7-canary.1470.18220.0
npm install @auto-canary/slack@9.50.7-canary.1470.18220.0
npm install @auto-canary/twitter@9.50.7-canary.1470.18220.0
npm install @auto-canary/upload-assets@9.50.7-canary.1470.18220.0
# or 
yarn add @auto-canary/bot-list@9.50.7-canary.1470.18220.0
yarn add @auto-canary/auto@9.50.7-canary.1470.18220.0
yarn add @auto-canary/core@9.50.7-canary.1470.18220.0
yarn add @auto-canary/all-contributors@9.50.7-canary.1470.18220.0
yarn add @auto-canary/brew@9.50.7-canary.1470.18220.0
yarn add @auto-canary/chrome@9.50.7-canary.1470.18220.0
yarn add @auto-canary/cocoapods@9.50.7-canary.1470.18220.0
yarn add @auto-canary/conventional-commits@9.50.7-canary.1470.18220.0
yarn add @auto-canary/crates@9.50.7-canary.1470.18220.0
yarn add @auto-canary/exec@9.50.7-canary.1470.18220.0
yarn add @auto-canary/first-time-contributor@9.50.7-canary.1470.18220.0
yarn add @auto-canary/gem@9.50.7-canary.1470.18220.0
yarn add @auto-canary/gh-pages@9.50.7-canary.1470.18220.0
yarn add @auto-canary/git-tag@9.50.7-canary.1470.18220.0
yarn add @auto-canary/gradle@9.50.7-canary.1470.18220.0
yarn add @auto-canary/jira@9.50.7-canary.1470.18220.0
yarn add @auto-canary/maven@9.50.7-canary.1470.18220.0
yarn add @auto-canary/npm@9.50.7-canary.1470.18220.0
yarn add @auto-canary/omit-commits@9.50.7-canary.1470.18220.0
yarn add @auto-canary/omit-release-notes@9.50.7-canary.1470.18220.0
yarn add @auto-canary/released@9.50.7-canary.1470.18220.0
yarn add @auto-canary/s3@9.50.7-canary.1470.18220.0
yarn add @auto-canary/slack@9.50.7-canary.1470.18220.0
yarn add @auto-canary/twitter@9.50.7-canary.1470.18220.0
yarn add @auto-canary/upload-assets@9.50.7-canary.1470.18220.0

@hipstersmoothie hipstersmoothie added the patch Increment the patch version when merged label Aug 14, 2020
@codecov
Copy link

codecov bot commented Aug 14, 2020

Codecov Report

Merging #1470 into master will decrease coverage by 0.05%.
The diff coverage is 81.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1470      +/-   ##
==========================================
- Coverage   81.12%   81.07%   -0.06%     
==========================================
  Files          58       58              
  Lines        4308     4317       +9     
  Branches      906      961      +55     
==========================================
+ Hits         3495     3500       +5     
- Misses        570      571       +1     
- Partials      243      246       +3     
Impacted Files Coverage Δ
packages/core/src/semver.ts 90.32% <81.81%> (-5.91%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d7a292...af5efa9. Read the comment docs.

@hipstersmoothie hipstersmoothie merged commit c846138 into master Aug 14, 2020
@hipstersmoothie hipstersmoothie deleted the default-bump branch August 14, 2020 16:00
@adierkens
Copy link
Collaborator

🚀 PR was released in v9.50.7 🚀

@adierkens adierkens added the released This issue/pull request has been released. label Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default to 'none'
2 participants