Add pr-body-labels plugin #1554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reubenae
approved these changes
Sep 30, 2020
Codecov Report
@@ Coverage Diff @@
## master #1554 +/- ##
=======================================
Coverage 81.21% 81.21%
=======================================
Files 59 60 +1
Lines 4396 4413 +17
Branches 932 986 +54
=======================================
+ Hits 3570 3584 +14
- Misses 572 573 +1
- Partials 254 256 +2
Continue to review full report at Codecov.
|
adierkens
reviewed
Sep 30, 2020
plugins/pr-body-labels/src/index.ts
Outdated
| return; | ||
| } | ||
|
|
||
| const projectLabels = await auto.git.getProjectLabels(); |
There was a problem hiding this comment.
Should this be limited to tags defined by the .auto config? Or does getProjectLabels() do that already?
There's a potential of this being abused to add any label (i.e. "merge when built") to a PR simply by adding a note in the PR body.
hipstersmoothie
force-pushed
the
pr-label-body
branch
from
8e2459a
to
ef838e5
Compare
hipstersmoothie
force-pushed
the
pr-label-body
branch
from
ef838e5
to
ba9f1bc
Compare
adierkens
approved these changes
Oct 1, 2020
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed
Add a plugin that detect GitHub labels in a PR body and adds them to the PR.
Why
Outside contributors can't add these labels
Todo:
Change Type
Indicate the type of change your pull request is:
documentationpatchminormajor📦 Published PR as canary version:
under canary scope @auto-canary@9.53.2-canary.1554.19032.0✨ Test out this PR locally via:
npm install @auto-canary/bot-list@9.53.2-canary.1554.19032.0 npm install @auto-canary/auto@9.53.2-canary.1554.19032.0 npm install @auto-canary/core@9.53.2-canary.1554.19032.0 npm install @auto-canary/all-contributors@9.53.2-canary.1554.19032.0 npm install @auto-canary/brew@9.53.2-canary.1554.19032.0 npm install @auto-canary/chrome@9.53.2-canary.1554.19032.0 npm install @auto-canary/cocoapods@9.53.2-canary.1554.19032.0 npm install @auto-canary/conventional-commits@9.53.2-canary.1554.19032.0 npm install @auto-canary/crates@9.53.2-canary.1554.19032.0 npm install @auto-canary/docker@9.53.2-canary.1554.19032.0 npm install @auto-canary/exec@9.53.2-canary.1554.19032.0 npm install @auto-canary/first-time-contributor@9.53.2-canary.1554.19032.0 npm install @auto-canary/gem@9.53.2-canary.1554.19032.0 npm install @auto-canary/gh-pages@9.53.2-canary.1554.19032.0 npm install @auto-canary/git-tag@9.53.2-canary.1554.19032.0 npm install @auto-canary/gradle@9.53.2-canary.1554.19032.0 npm install @auto-canary/jira@9.53.2-canary.1554.19032.0 npm install @auto-canary/maven@9.53.2-canary.1554.19032.0 npm install @auto-canary/npm@9.53.2-canary.1554.19032.0 npm install @auto-canary/omit-commits@9.53.2-canary.1554.19032.0 npm install @auto-canary/omit-release-notes@9.53.2-canary.1554.19032.0 npm install @auto-canary/pr-body-labels@9.53.2-canary.1554.19032.0 npm install @auto-canary/released@9.53.2-canary.1554.19032.0 npm install @auto-canary/s3@9.53.2-canary.1554.19032.0 npm install @auto-canary/slack@9.53.2-canary.1554.19032.0 npm install @auto-canary/twitter@9.53.2-canary.1554.19032.0 npm install @auto-canary/upload-assets@9.53.2-canary.1554.19032.0 # or yarn add @auto-canary/bot-list@9.53.2-canary.1554.19032.0 yarn add @auto-canary/auto@9.53.2-canary.1554.19032.0 yarn add @auto-canary/core@9.53.2-canary.1554.19032.0 yarn add @auto-canary/all-contributors@9.53.2-canary.1554.19032.0 yarn add @auto-canary/brew@9.53.2-canary.1554.19032.0 yarn add @auto-canary/chrome@9.53.2-canary.1554.19032.0 yarn add @auto-canary/cocoapods@9.53.2-canary.1554.19032.0 yarn add @auto-canary/conventional-commits@9.53.2-canary.1554.19032.0 yarn add @auto-canary/crates@9.53.2-canary.1554.19032.0 yarn add @auto-canary/docker@9.53.2-canary.1554.19032.0 yarn add @auto-canary/exec@9.53.2-canary.1554.19032.0 yarn add @auto-canary/first-time-contributor@9.53.2-canary.1554.19032.0 yarn add @auto-canary/gem@9.53.2-canary.1554.19032.0 yarn add @auto-canary/gh-pages@9.53.2-canary.1554.19032.0 yarn add @auto-canary/git-tag@9.53.2-canary.1554.19032.0 yarn add @auto-canary/gradle@9.53.2-canary.1554.19032.0 yarn add @auto-canary/jira@9.53.2-canary.1554.19032.0 yarn add @auto-canary/maven@9.53.2-canary.1554.19032.0 yarn add @auto-canary/npm@9.53.2-canary.1554.19032.0 yarn add @auto-canary/omit-commits@9.53.2-canary.1554.19032.0 yarn add @auto-canary/omit-release-notes@9.53.2-canary.1554.19032.0 yarn add @auto-canary/pr-body-labels@9.53.2-canary.1554.19032.0 yarn add @auto-canary/released@9.53.2-canary.1554.19032.0 yarn add @auto-canary/s3@9.53.2-canary.1554.19032.0 yarn add @auto-canary/slack@9.53.2-canary.1554.19032.0 yarn add @auto-canary/twitter@9.53.2-canary.1554.19032.0 yarn add @auto-canary/upload-assets@9.53.2-canary.1554.19032.0