Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ssh support for connecting to github #1590

Merged
merged 8 commits into from
Nov 2, 2020

Conversation

tinytim84
Copy link
Contributor

@tinytim84 tinytim84 commented Oct 15, 2020

What Changed

Added support for SSH when connecting to github.

Why

It gives another route to connect to github that doesn't rely on personal access token

Todo:

  • Add tests
  • Add docs (if required, this change wouldn't require any explicit action from the user)

Change Type

Indicate the type of change your pull request is:

  • documentation
  • patch
  • minor
  • major
📦 Published PR as canary version: under canary scope @auto-canary@10.0.3-canary.1590.19966.0

✨ Test out this PR locally via:

npm install @auto-canary/bot-list@10.0.3-canary.1590.19966.0
npm install @auto-canary/auto@10.0.3-canary.1590.19966.0
npm install @auto-canary/core@10.0.3-canary.1590.19966.0
npm install @auto-canary/all-contributors@10.0.3-canary.1590.19966.0
npm install @auto-canary/brew@10.0.3-canary.1590.19966.0
npm install @auto-canary/chrome@10.0.3-canary.1590.19966.0
npm install @auto-canary/cocoapods@10.0.3-canary.1590.19966.0
npm install @auto-canary/conventional-commits@10.0.3-canary.1590.19966.0
npm install @auto-canary/crates@10.0.3-canary.1590.19966.0
npm install @auto-canary/docker@10.0.3-canary.1590.19966.0
npm install @auto-canary/exec@10.0.3-canary.1590.19966.0
npm install @auto-canary/first-time-contributor@10.0.3-canary.1590.19966.0
npm install @auto-canary/gem@10.0.3-canary.1590.19966.0
npm install @auto-canary/gh-pages@10.0.3-canary.1590.19966.0
npm install @auto-canary/git-tag@10.0.3-canary.1590.19966.0
npm install @auto-canary/gradle@10.0.3-canary.1590.19966.0
npm install @auto-canary/jira@10.0.3-canary.1590.19966.0
npm install @auto-canary/maven@10.0.3-canary.1590.19966.0
npm install @auto-canary/npm@10.0.3-canary.1590.19966.0
npm install @auto-canary/omit-commits@10.0.3-canary.1590.19966.0
npm install @auto-canary/omit-release-notes@10.0.3-canary.1590.19966.0
npm install @auto-canary/pr-body-labels@10.0.3-canary.1590.19966.0
npm install @auto-canary/released@10.0.3-canary.1590.19966.0
npm install @auto-canary/s3@10.0.3-canary.1590.19966.0
npm install @auto-canary/slack@10.0.3-canary.1590.19966.0
npm install @auto-canary/twitter@10.0.3-canary.1590.19966.0
npm install @auto-canary/upload-assets@10.0.3-canary.1590.19966.0
# or 
yarn add @auto-canary/bot-list@10.0.3-canary.1590.19966.0
yarn add @auto-canary/auto@10.0.3-canary.1590.19966.0
yarn add @auto-canary/core@10.0.3-canary.1590.19966.0
yarn add @auto-canary/all-contributors@10.0.3-canary.1590.19966.0
yarn add @auto-canary/brew@10.0.3-canary.1590.19966.0
yarn add @auto-canary/chrome@10.0.3-canary.1590.19966.0
yarn add @auto-canary/cocoapods@10.0.3-canary.1590.19966.0
yarn add @auto-canary/conventional-commits@10.0.3-canary.1590.19966.0
yarn add @auto-canary/crates@10.0.3-canary.1590.19966.0
yarn add @auto-canary/docker@10.0.3-canary.1590.19966.0
yarn add @auto-canary/exec@10.0.3-canary.1590.19966.0
yarn add @auto-canary/first-time-contributor@10.0.3-canary.1590.19966.0
yarn add @auto-canary/gem@10.0.3-canary.1590.19966.0
yarn add @auto-canary/gh-pages@10.0.3-canary.1590.19966.0
yarn add @auto-canary/git-tag@10.0.3-canary.1590.19966.0
yarn add @auto-canary/gradle@10.0.3-canary.1590.19966.0
yarn add @auto-canary/jira@10.0.3-canary.1590.19966.0
yarn add @auto-canary/maven@10.0.3-canary.1590.19966.0
yarn add @auto-canary/npm@10.0.3-canary.1590.19966.0
yarn add @auto-canary/omit-commits@10.0.3-canary.1590.19966.0
yarn add @auto-canary/omit-release-notes@10.0.3-canary.1590.19966.0
yarn add @auto-canary/pr-body-labels@10.0.3-canary.1590.19966.0
yarn add @auto-canary/released@10.0.3-canary.1590.19966.0
yarn add @auto-canary/s3@10.0.3-canary.1590.19966.0
yarn add @auto-canary/slack@10.0.3-canary.1590.19966.0
yarn add @auto-canary/twitter@10.0.3-canary.1590.19966.0
yarn add @auto-canary/upload-assets@10.0.3-canary.1590.19966.0

@adierkens adierkens added the minor Increment the minor version when merged label Oct 15, 2020
@codecov
Copy link

codecov bot commented Oct 15, 2020

Codecov Report

Merging #1590 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1590      +/-   ##
==========================================
+ Coverage   81.19%   81.20%   +0.01%     
==========================================
  Files          60       60              
  Lines        4461     4464       +3     
  Branches     1003      955      -48     
==========================================
+ Hits         3622     3625       +3     
  Misses        577      577              
  Partials      262      262              
Impacted Files Coverage Δ
packages/core/src/auto.ts 77.32% <100.00%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccf76d0...3aaf325. Read the comment docs.

@hipstersmoothie
Copy link
Collaborator

@tinytim84 can you test with the new canary version?

@hipstersmoothie
Copy link
Collaborator

@tinytim84 Have you tested this? is this good to merge?

@tinytim84
Copy link
Contributor Author

@hipstersmoothie I got pulled onto something else and then had a few days off, but I'm back looking at this again now. I think it needs one more change before it's ready to merge. I'll hoping to have it ready by Monday.

@tinytim84
Copy link
Contributor Author

The canary release was successful, so this change is ready to go if you're happy with it.

@hipstersmoothie
Copy link
Collaborator

Awesome!

@tinytim84
Copy link
Contributor Author

Awesome!

There's still a slight issue that I'm working on now. I think I may have removed something I shouldn't have.

@hipstersmoothie
Copy link
Collaborator

Thanks for all your work and testing on this!

@hipstersmoothie hipstersmoothie merged commit e84471a into intuit:master Nov 2, 2020
@adierkens
Copy link
Collaborator

🚀 PR was released in v10.1.0 🚀

@adierkens adierkens added the released This issue/pull request has been released. label Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Increment the minor version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants