Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix non-ssh release #1629

Merged
merged 1 commit into from Nov 2, 2020
Merged

Fix non-ssh release #1629

merged 1 commit into from Nov 2, 2020

Conversation

hipstersmoothie
Copy link
Collaborator

@hipstersmoothie hipstersmoothie commented Nov 2, 2020

What Changed

Improve verifyAuth check to included ssh errors

Why

I like it when the release works

Change Type

Indicate the type of change your pull request is:

  • documentation
  • patch
  • minor
  • major
📦 Published PR as canary version: under canary scope @auto-canary@10.0.3-canary.1629.20078.0

✨ Test out this PR locally via:

npm install @auto-canary/bot-list@10.0.3-canary.1629.20078.0
npm install @auto-canary/auto@10.0.3-canary.1629.20078.0
npm install @auto-canary/core@10.0.3-canary.1629.20078.0
npm install @auto-canary/all-contributors@10.0.3-canary.1629.20078.0
npm install @auto-canary/brew@10.0.3-canary.1629.20078.0
npm install @auto-canary/chrome@10.0.3-canary.1629.20078.0
npm install @auto-canary/cocoapods@10.0.3-canary.1629.20078.0
npm install @auto-canary/conventional-commits@10.0.3-canary.1629.20078.0
npm install @auto-canary/crates@10.0.3-canary.1629.20078.0
npm install @auto-canary/docker@10.0.3-canary.1629.20078.0
npm install @auto-canary/exec@10.0.3-canary.1629.20078.0
npm install @auto-canary/first-time-contributor@10.0.3-canary.1629.20078.0
npm install @auto-canary/gem@10.0.3-canary.1629.20078.0
npm install @auto-canary/gh-pages@10.0.3-canary.1629.20078.0
npm install @auto-canary/git-tag@10.0.3-canary.1629.20078.0
npm install @auto-canary/gradle@10.0.3-canary.1629.20078.0
npm install @auto-canary/jira@10.0.3-canary.1629.20078.0
npm install @auto-canary/maven@10.0.3-canary.1629.20078.0
npm install @auto-canary/npm@10.0.3-canary.1629.20078.0
npm install @auto-canary/omit-commits@10.0.3-canary.1629.20078.0
npm install @auto-canary/omit-release-notes@10.0.3-canary.1629.20078.0
npm install @auto-canary/pr-body-labels@10.0.3-canary.1629.20078.0
npm install @auto-canary/released@10.0.3-canary.1629.20078.0
npm install @auto-canary/s3@10.0.3-canary.1629.20078.0
npm install @auto-canary/slack@10.0.3-canary.1629.20078.0
npm install @auto-canary/twitter@10.0.3-canary.1629.20078.0
npm install @auto-canary/upload-assets@10.0.3-canary.1629.20078.0
# or 
yarn add @auto-canary/bot-list@10.0.3-canary.1629.20078.0
yarn add @auto-canary/auto@10.0.3-canary.1629.20078.0
yarn add @auto-canary/core@10.0.3-canary.1629.20078.0
yarn add @auto-canary/all-contributors@10.0.3-canary.1629.20078.0
yarn add @auto-canary/brew@10.0.3-canary.1629.20078.0
yarn add @auto-canary/chrome@10.0.3-canary.1629.20078.0
yarn add @auto-canary/cocoapods@10.0.3-canary.1629.20078.0
yarn add @auto-canary/conventional-commits@10.0.3-canary.1629.20078.0
yarn add @auto-canary/crates@10.0.3-canary.1629.20078.0
yarn add @auto-canary/docker@10.0.3-canary.1629.20078.0
yarn add @auto-canary/exec@10.0.3-canary.1629.20078.0
yarn add @auto-canary/first-time-contributor@10.0.3-canary.1629.20078.0
yarn add @auto-canary/gem@10.0.3-canary.1629.20078.0
yarn add @auto-canary/gh-pages@10.0.3-canary.1629.20078.0
yarn add @auto-canary/git-tag@10.0.3-canary.1629.20078.0
yarn add @auto-canary/gradle@10.0.3-canary.1629.20078.0
yarn add @auto-canary/jira@10.0.3-canary.1629.20078.0
yarn add @auto-canary/maven@10.0.3-canary.1629.20078.0
yarn add @auto-canary/npm@10.0.3-canary.1629.20078.0
yarn add @auto-canary/omit-commits@10.0.3-canary.1629.20078.0
yarn add @auto-canary/omit-release-notes@10.0.3-canary.1629.20078.0
yarn add @auto-canary/pr-body-labels@10.0.3-canary.1629.20078.0
yarn add @auto-canary/released@10.0.3-canary.1629.20078.0
yarn add @auto-canary/s3@10.0.3-canary.1629.20078.0
yarn add @auto-canary/slack@10.0.3-canary.1629.20078.0
yarn add @auto-canary/twitter@10.0.3-canary.1629.20078.0
yarn add @auto-canary/upload-assets@10.0.3-canary.1629.20078.0

@codecov
Copy link

codecov bot commented Nov 2, 2020

Codecov Report

Merging #1629 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1629   +/-   ##
=======================================
  Coverage   81.20%   81.20%           
=======================================
  Files          60       60           
  Lines        4464     4465    +1     
  Branches      955      956    +1     
=======================================
+ Hits         3625     3626    +1     
  Misses        577      577           
  Partials      262      262           
Impacted Files Coverage Δ
packages/core/src/utils/verify-auth.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3aaf325...1ab7336. Read the comment docs.

@hipstersmoothie hipstersmoothie added the patch Increment the patch version when merged label Nov 2, 2020
@hipstersmoothie hipstersmoothie merged commit 62e9f23 into master Nov 2, 2020
@hipstersmoothie hipstersmoothie deleted the ssh-bug branch November 2, 2020 19:01
@adierkens
Copy link
Collaborator

🚀 PR was released in v10.1.0 🚀

@adierkens adierkens added the released This issue/pull request has been released. label Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants