Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Truncate commit hash for shorter canary versions #1635

Merged
merged 1 commit into from
Nov 6, 2020

Conversation

hipstersmoothie
Copy link
Collaborator

@hipstersmoothie hipstersmoothie commented Nov 6, 2020

What Changed

Make the commit hashes shorter in canary versions where no build or PR is detected

Why

The full commit hash is a little much

Todo:

  • Add tests

Change Type

Indicate the type of change your pull request is:

  • documentation
  • patch
  • minor
  • major
📦 Published PR as canary version: under canary scope @auto-canary@10.2.4-canary.1635.20175.0

✨ Test out this PR locally via:

npm install @auto-canary/bot-list@10.2.4-canary.1635.20175.0
npm install @auto-canary/auto@10.2.4-canary.1635.20175.0
npm install @auto-canary/core@10.2.4-canary.1635.20175.0
npm install @auto-canary/all-contributors@10.2.4-canary.1635.20175.0
npm install @auto-canary/brew@10.2.4-canary.1635.20175.0
npm install @auto-canary/chrome@10.2.4-canary.1635.20175.0
npm install @auto-canary/cocoapods@10.2.4-canary.1635.20175.0
npm install @auto-canary/conventional-commits@10.2.4-canary.1635.20175.0
npm install @auto-canary/crates@10.2.4-canary.1635.20175.0
npm install @auto-canary/docker@10.2.4-canary.1635.20175.0
npm install @auto-canary/exec@10.2.4-canary.1635.20175.0
npm install @auto-canary/first-time-contributor@10.2.4-canary.1635.20175.0
npm install @auto-canary/gem@10.2.4-canary.1635.20175.0
npm install @auto-canary/gh-pages@10.2.4-canary.1635.20175.0
npm install @auto-canary/git-tag@10.2.4-canary.1635.20175.0
npm install @auto-canary/gradle@10.2.4-canary.1635.20175.0
npm install @auto-canary/jira@10.2.4-canary.1635.20175.0
npm install @auto-canary/maven@10.2.4-canary.1635.20175.0
npm install @auto-canary/microsoft-teams@10.2.4-canary.1635.20175.0
npm install @auto-canary/npm@10.2.4-canary.1635.20175.0
npm install @auto-canary/omit-commits@10.2.4-canary.1635.20175.0
npm install @auto-canary/omit-release-notes@10.2.4-canary.1635.20175.0
npm install @auto-canary/pr-body-labels@10.2.4-canary.1635.20175.0
npm install @auto-canary/released@10.2.4-canary.1635.20175.0
npm install @auto-canary/s3@10.2.4-canary.1635.20175.0
npm install @auto-canary/slack@10.2.4-canary.1635.20175.0
npm install @auto-canary/twitter@10.2.4-canary.1635.20175.0
npm install @auto-canary/upload-assets@10.2.4-canary.1635.20175.0
# or 
yarn add @auto-canary/bot-list@10.2.4-canary.1635.20175.0
yarn add @auto-canary/auto@10.2.4-canary.1635.20175.0
yarn add @auto-canary/core@10.2.4-canary.1635.20175.0
yarn add @auto-canary/all-contributors@10.2.4-canary.1635.20175.0
yarn add @auto-canary/brew@10.2.4-canary.1635.20175.0
yarn add @auto-canary/chrome@10.2.4-canary.1635.20175.0
yarn add @auto-canary/cocoapods@10.2.4-canary.1635.20175.0
yarn add @auto-canary/conventional-commits@10.2.4-canary.1635.20175.0
yarn add @auto-canary/crates@10.2.4-canary.1635.20175.0
yarn add @auto-canary/docker@10.2.4-canary.1635.20175.0
yarn add @auto-canary/exec@10.2.4-canary.1635.20175.0
yarn add @auto-canary/first-time-contributor@10.2.4-canary.1635.20175.0
yarn add @auto-canary/gem@10.2.4-canary.1635.20175.0
yarn add @auto-canary/gh-pages@10.2.4-canary.1635.20175.0
yarn add @auto-canary/git-tag@10.2.4-canary.1635.20175.0
yarn add @auto-canary/gradle@10.2.4-canary.1635.20175.0
yarn add @auto-canary/jira@10.2.4-canary.1635.20175.0
yarn add @auto-canary/maven@10.2.4-canary.1635.20175.0
yarn add @auto-canary/microsoft-teams@10.2.4-canary.1635.20175.0
yarn add @auto-canary/npm@10.2.4-canary.1635.20175.0
yarn add @auto-canary/omit-commits@10.2.4-canary.1635.20175.0
yarn add @auto-canary/omit-release-notes@10.2.4-canary.1635.20175.0
yarn add @auto-canary/pr-body-labels@10.2.4-canary.1635.20175.0
yarn add @auto-canary/released@10.2.4-canary.1635.20175.0
yarn add @auto-canary/s3@10.2.4-canary.1635.20175.0
yarn add @auto-canary/slack@10.2.4-canary.1635.20175.0
yarn add @auto-canary/twitter@10.2.4-canary.1635.20175.0
yarn add @auto-canary/upload-assets@10.2.4-canary.1635.20175.0

@codecov
Copy link

codecov bot commented Nov 6, 2020

Codecov Report

Merging #1635 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1635   +/-   ##
=======================================
  Coverage   80.27%   80.27%           
=======================================
  Files          61       61           
  Lines        4655     4655           
  Branches     1059     1009   -50     
=======================================
  Hits         3737     3737           
  Misses        632      632           
  Partials      286      286           
Impacted Files Coverage Δ
packages/core/src/auto.ts 78.40% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a962ba2...ec34caf. Read the comment docs.

@hipstersmoothie hipstersmoothie merged commit 993502e into master Nov 6, 2020
@hipstersmoothie hipstersmoothie deleted the truncate-hash branch November 6, 2020 18:04
@adierkens
Copy link
Collaborator

🚀 PR was released in v10.2.4 🚀

@adierkens adierkens added the released This issue/pull request has been released. label Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants