Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix npm plugin git tag splitting #1705

Merged
merged 1 commit into from
Jan 11, 2021
Merged

Conversation

AndrewLeedham
Copy link
Contributor

What Changed

Gets rid of empty tags when getting current repo tags in the npm plugin.

Why

fixes: #1704

Change Type

Indicate the type of change your pull request is:

  • documentation
  • patch
  • minor
  • major

@adierkens adierkens added the patch Increment the patch version when merged label Jan 11, 2021
@codecov
Copy link

codecov bot commented Jan 11, 2021

Codecov Report

Merging #1705 (30a5fa0) into master (ed7ec60) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1705   +/-   ##
=======================================
  Coverage   80.23%   80.24%           
=======================================
  Files          61       61           
  Lines        4665     4666    +1     
  Branches     1013     1063   +50     
=======================================
+ Hits         3743     3744    +1     
  Misses        633      633           
  Partials      289      289           
Impacted Files Coverage Δ
plugins/npm/src/index.ts 74.27% <100.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed7ec60...30a5fa0. Read the comment docs.

@AndrewLeedham AndrewLeedham marked this pull request as ready for review January 11, 2021 13:19
@hipstersmoothie
Copy link
Collaborator

Thanks for the contribution!

@hipstersmoothie hipstersmoothie merged commit bd95ace into intuit:master Jan 11, 2021
@adierkens
Copy link
Collaborator

🚀 PR was released in v10.6.0 🚀

@adierkens adierkens added the released This issue/pull request has been released. label Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

git tag --points-at HEAD including blank string
3 participants