Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to resolve relative plugin paths from extended config location #1717

Merged
merged 1 commit into from
Jan 14, 2021

Conversation

hipstersmoothie
Copy link
Collaborator

@hipstersmoothie hipstersmoothie commented Jan 14, 2021

What Changed

see title

Why

closes #1712

Todo:

  • Add tests
  • Add docs

Change Type

Indicate the type of change your pull request is:

  • documentation
  • patch
  • minor
  • major
📦 Published PR as canary version: under canary scope @auto-canary@10.6.3-canary.1717.21114.0

✨ Test out this PR locally via:

npm install @auto-canary/bot-list@10.6.3-canary.1717.21114.0
npm install @auto-canary/auto@10.6.3-canary.1717.21114.0
npm install @auto-canary/core@10.6.3-canary.1717.21114.0
npm install @auto-canary/package-json-utils@10.6.3-canary.1717.21114.0
npm install @auto-canary/all-contributors@10.6.3-canary.1717.21114.0
npm install @auto-canary/brew@10.6.3-canary.1717.21114.0
npm install @auto-canary/chrome@10.6.3-canary.1717.21114.0
npm install @auto-canary/cocoapods@10.6.3-canary.1717.21114.0
npm install @auto-canary/conventional-commits@10.6.3-canary.1717.21114.0
npm install @auto-canary/crates@10.6.3-canary.1717.21114.0
npm install @auto-canary/docker@10.6.3-canary.1717.21114.0
npm install @auto-canary/exec@10.6.3-canary.1717.21114.0
npm install @auto-canary/first-time-contributor@10.6.3-canary.1717.21114.0
npm install @auto-canary/gem@10.6.3-canary.1717.21114.0
npm install @auto-canary/gh-pages@10.6.3-canary.1717.21114.0
npm install @auto-canary/git-tag@10.6.3-canary.1717.21114.0
npm install @auto-canary/gradle@10.6.3-canary.1717.21114.0
npm install @auto-canary/jira@10.6.3-canary.1717.21114.0
npm install @auto-canary/maven@10.6.3-canary.1717.21114.0
npm install @auto-canary/microsoft-teams@10.6.3-canary.1717.21114.0
npm install @auto-canary/npm@10.6.3-canary.1717.21114.0
npm install @auto-canary/omit-commits@10.6.3-canary.1717.21114.0
npm install @auto-canary/omit-release-notes@10.6.3-canary.1717.21114.0
npm install @auto-canary/pr-body-labels@10.6.3-canary.1717.21114.0
npm install @auto-canary/released@10.6.3-canary.1717.21114.0
npm install @auto-canary/s3@10.6.3-canary.1717.21114.0
npm install @auto-canary/slack@10.6.3-canary.1717.21114.0
npm install @auto-canary/twitter@10.6.3-canary.1717.21114.0
npm install @auto-canary/upload-assets@10.6.3-canary.1717.21114.0
npm install @auto-canary/vscode@10.6.3-canary.1717.21114.0
# or 
yarn add @auto-canary/bot-list@10.6.3-canary.1717.21114.0
yarn add @auto-canary/auto@10.6.3-canary.1717.21114.0
yarn add @auto-canary/core@10.6.3-canary.1717.21114.0
yarn add @auto-canary/package-json-utils@10.6.3-canary.1717.21114.0
yarn add @auto-canary/all-contributors@10.6.3-canary.1717.21114.0
yarn add @auto-canary/brew@10.6.3-canary.1717.21114.0
yarn add @auto-canary/chrome@10.6.3-canary.1717.21114.0
yarn add @auto-canary/cocoapods@10.6.3-canary.1717.21114.0
yarn add @auto-canary/conventional-commits@10.6.3-canary.1717.21114.0
yarn add @auto-canary/crates@10.6.3-canary.1717.21114.0
yarn add @auto-canary/docker@10.6.3-canary.1717.21114.0
yarn add @auto-canary/exec@10.6.3-canary.1717.21114.0
yarn add @auto-canary/first-time-contributor@10.6.3-canary.1717.21114.0
yarn add @auto-canary/gem@10.6.3-canary.1717.21114.0
yarn add @auto-canary/gh-pages@10.6.3-canary.1717.21114.0
yarn add @auto-canary/git-tag@10.6.3-canary.1717.21114.0
yarn add @auto-canary/gradle@10.6.3-canary.1717.21114.0
yarn add @auto-canary/jira@10.6.3-canary.1717.21114.0
yarn add @auto-canary/maven@10.6.3-canary.1717.21114.0
yarn add @auto-canary/microsoft-teams@10.6.3-canary.1717.21114.0
yarn add @auto-canary/npm@10.6.3-canary.1717.21114.0
yarn add @auto-canary/omit-commits@10.6.3-canary.1717.21114.0
yarn add @auto-canary/omit-release-notes@10.6.3-canary.1717.21114.0
yarn add @auto-canary/pr-body-labels@10.6.3-canary.1717.21114.0
yarn add @auto-canary/released@10.6.3-canary.1717.21114.0
yarn add @auto-canary/s3@10.6.3-canary.1717.21114.0
yarn add @auto-canary/slack@10.6.3-canary.1717.21114.0
yarn add @auto-canary/twitter@10.6.3-canary.1717.21114.0
yarn add @auto-canary/upload-assets@10.6.3-canary.1717.21114.0
yarn add @auto-canary/vscode@10.6.3-canary.1717.21114.0

@adierkens adierkens added the minor Increment the minor version when merged label Jan 14, 2021
@codecov
Copy link

codecov bot commented Jan 14, 2021

Codecov Report

Merging #1717 (d129e79) into master (f29b6ed) will increase coverage by 0.12%.
The diff coverage is 58.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1717      +/-   ##
==========================================
+ Coverage   80.05%   80.18%   +0.12%     
==========================================
  Files          63       63              
  Lines        4788     4794       +6     
  Branches     1090     1094       +4     
==========================================
+ Hits         3833     3844      +11     
+ Misses        658      653       -5     
  Partials      297      297              
Impacted Files Coverage Δ
packages/core/src/utils/load-plugins.ts 81.73% <50.00%> (+0.54%) ⬆️
packages/core/src/auto.ts 78.36% <75.00%> (-0.05%) ⬇️
packages/core/src/utils/logger.ts 80.00% <0.00%> (+10.00%) ⬆️
packages/core/src/utils/try-require.ts 100.00% <0.00%> (+22.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f29b6ed...4c5bdd2. Read the comment docs.

@adierkens
Copy link
Collaborator

🚀 PR was released in v10.7.0 🚀

@adierkens adierkens added the released This issue/pull request has been released. label Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Increment the minor version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

relative plugins from external config shared across packages breaks
2 participants