properly kill spawned node child processes

[hipstersmoothie]

What Changed

Node's spawn with shell and detacted set to true will spawn child processes that aren't killed when killing the parent process. This PR attempts to kill all the children of the spawned process too.

Why

This hanging spawn was adding minutes of waiting time to the simplest auto use cases.

Change Type

Indicate the type of change your pull request is:

• documentation
• patch
• minor
• major

🐤 Download canary assets:

auto-linux-canary.1732.21269.gz
auto-macos-canary.1732.21269.gz
auto-win.exe-canary.1732.21269.gz

📦 Published PR as canary version: under canary scope @auto-canary@10.10.1-canary.1732.21269.0

✨ Test out this PR locally via:

npm install @auto-canary/bot-list@10.10.1-canary.1732.21269.0
npm install @auto-canary/auto@10.10.1-canary.1732.21269.0
npm install @auto-canary/core@10.10.1-canary.1732.21269.0
npm install @auto-canary/package-json-utils@10.10.1-canary.1732.21269.0
npm install @auto-canary/all-contributors@10.10.1-canary.1732.21269.0
npm install @auto-canary/brew@10.10.1-canary.1732.21269.0
npm install @auto-canary/chrome@10.10.1-canary.1732.21269.0
npm install @auto-canary/cocoapods@10.10.1-canary.1732.21269.0
npm install @auto-canary/conventional-commits@10.10.1-canary.1732.21269.0
npm install @auto-canary/crates@10.10.1-canary.1732.21269.0
npm install @auto-canary/docker@10.10.1-canary.1732.21269.0
npm install @auto-canary/exec@10.10.1-canary.1732.21269.0
npm install @auto-canary/first-time-contributor@10.10.1-canary.1732.21269.0
npm install @auto-canary/gem@10.10.1-canary.1732.21269.0
npm install @auto-canary/gh-pages@10.10.1-canary.1732.21269.0
npm install @auto-canary/git-tag@10.10.1-canary.1732.21269.0
npm install @auto-canary/gradle@10.10.1-canary.1732.21269.0
npm install @auto-canary/jira@10.10.1-canary.1732.21269.0
npm install @auto-canary/maven@10.10.1-canary.1732.21269.0
npm install @auto-canary/microsoft-teams@10.10.1-canary.1732.21269.0
npm install @auto-canary/npm@10.10.1-canary.1732.21269.0
npm install @auto-canary/omit-commits@10.10.1-canary.1732.21269.0
npm install @auto-canary/omit-release-notes@10.10.1-canary.1732.21269.0
npm install @auto-canary/pr-body-labels@10.10.1-canary.1732.21269.0
npm install @auto-canary/released@10.10.1-canary.1732.21269.0
npm install @auto-canary/s3@10.10.1-canary.1732.21269.0
npm install @auto-canary/slack@10.10.1-canary.1732.21269.0
npm install @auto-canary/twitter@10.10.1-canary.1732.21269.0
npm install @auto-canary/upload-assets@10.10.1-canary.1732.21269.0
npm install @auto-canary/vscode@10.10.1-canary.1732.21269.0
# or 
yarn add @auto-canary/bot-list@10.10.1-canary.1732.21269.0
yarn add @auto-canary/auto@10.10.1-canary.1732.21269.0
yarn add @auto-canary/core@10.10.1-canary.1732.21269.0
yarn add @auto-canary/package-json-utils@10.10.1-canary.1732.21269.0
yarn add @auto-canary/all-contributors@10.10.1-canary.1732.21269.0
yarn add @auto-canary/brew@10.10.1-canary.1732.21269.0
yarn add @auto-canary/chrome@10.10.1-canary.1732.21269.0
yarn add @auto-canary/cocoapods@10.10.1-canary.1732.21269.0
yarn add @auto-canary/conventional-commits@10.10.1-canary.1732.21269.0
yarn add @auto-canary/crates@10.10.1-canary.1732.21269.0
yarn add @auto-canary/docker@10.10.1-canary.1732.21269.0
yarn add @auto-canary/exec@10.10.1-canary.1732.21269.0
yarn add @auto-canary/first-time-contributor@10.10.1-canary.1732.21269.0
yarn add @auto-canary/gem@10.10.1-canary.1732.21269.0
yarn add @auto-canary/gh-pages@10.10.1-canary.1732.21269.0
yarn add @auto-canary/git-tag@10.10.1-canary.1732.21269.0
yarn add @auto-canary/gradle@10.10.1-canary.1732.21269.0
yarn add @auto-canary/jira@10.10.1-canary.1732.21269.0
yarn add @auto-canary/maven@10.10.1-canary.1732.21269.0
yarn add @auto-canary/microsoft-teams@10.10.1-canary.1732.21269.0
yarn add @auto-canary/npm@10.10.1-canary.1732.21269.0
yarn add @auto-canary/omit-commits@10.10.1-canary.1732.21269.0
yarn add @auto-canary/omit-release-notes@10.10.1-canary.1732.21269.0
yarn add @auto-canary/pr-body-labels@10.10.1-canary.1732.21269.0
yarn add @auto-canary/released@10.10.1-canary.1732.21269.0
yarn add @auto-canary/s3@10.10.1-canary.1732.21269.0
yarn add @auto-canary/slack@10.10.1-canary.1732.21269.0
yarn add @auto-canary/twitter@10.10.1-canary.1732.21269.0
yarn add @auto-canary/upload-assets@10.10.1-canary.1732.21269.0
yarn add @auto-canary/vscode@10.10.1-canary.1732.21269.0

[codecov]

Codecov Report

Merging #1732 (a460ec1) into master (c708200) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master    #1732   +/-   ##
=======================================
  Coverage   80.38%   80.38%           
=======================================
  Files          63       63           
  Lines        4890     4890           
  Branches     1068     1068           
=======================================
  Hits         3931     3931           
  Misses        656      656           
  Partials      303      303           

Impacted Files	Coverage Δ
packages/core/src/utils/verify-auth.ts	85.71% <0.00%> (ø)
plugins/upload-assets/src/index.ts	90.56% <ø> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eea5bd4...a460ec1. Read the comment docs.

[adierkens]

🚀 PR was released in v10.10.1 🚀