Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

respect skip and none releases for prereleases #1738

Merged
merged 1 commit into from Jan 21, 2021
Merged

Conversation

hipstersmoothie
Copy link
Collaborator

@hipstersmoothie hipstersmoothie commented Jan 21, 2021

What Changed

see title

Why

closes #1737

Todo:

  • Add tests

Change Type

Indicate the type of change your pull request is:

  • documentation
  • patch
  • minor
  • major

🐤 Download canary assets:

auto-linux-canary.1738.21372.gz
auto-macos-canary.1738.21372.gz
auto-win.exe-canary.1738.21372.gz

📦 Published PR as canary version: under canary scope @auto-canary@10.12.2-canary.1738.21388.0

✨ Test out this PR locally via:

npm install @auto-canary/bot-list@10.12.2-canary.1738.21388.0
npm install @auto-canary/auto@10.12.2-canary.1738.21388.0
npm install @auto-canary/core@10.12.2-canary.1738.21388.0
npm install @auto-canary/package-json-utils@10.12.2-canary.1738.21388.0
npm install @auto-canary/all-contributors@10.12.2-canary.1738.21388.0
npm install @auto-canary/brew@10.12.2-canary.1738.21388.0
npm install @auto-canary/chrome@10.12.2-canary.1738.21388.0
npm install @auto-canary/cocoapods@10.12.2-canary.1738.21388.0
npm install @auto-canary/conventional-commits@10.12.2-canary.1738.21388.0
npm install @auto-canary/crates@10.12.2-canary.1738.21388.0
npm install @auto-canary/docker@10.12.2-canary.1738.21388.0
npm install @auto-canary/exec@10.12.2-canary.1738.21388.0
npm install @auto-canary/first-time-contributor@10.12.2-canary.1738.21388.0
npm install @auto-canary/gem@10.12.2-canary.1738.21388.0
npm install @auto-canary/gh-pages@10.12.2-canary.1738.21388.0
npm install @auto-canary/git-tag@10.12.2-canary.1738.21388.0
npm install @auto-canary/gradle@10.12.2-canary.1738.21388.0
npm install @auto-canary/jira@10.12.2-canary.1738.21388.0
npm install @auto-canary/maven@10.12.2-canary.1738.21388.0
npm install @auto-canary/microsoft-teams@10.12.2-canary.1738.21388.0
npm install @auto-canary/npm@10.12.2-canary.1738.21388.0
npm install @auto-canary/omit-commits@10.12.2-canary.1738.21388.0
npm install @auto-canary/omit-release-notes@10.12.2-canary.1738.21388.0
npm install @auto-canary/pr-body-labels@10.12.2-canary.1738.21388.0
npm install @auto-canary/released@10.12.2-canary.1738.21388.0
npm install @auto-canary/s3@10.12.2-canary.1738.21388.0
npm install @auto-canary/slack@10.12.2-canary.1738.21388.0
npm install @auto-canary/twitter@10.12.2-canary.1738.21388.0
npm install @auto-canary/upload-assets@10.12.2-canary.1738.21388.0
npm install @auto-canary/vscode@10.12.2-canary.1738.21388.0
# or 
yarn add @auto-canary/bot-list@10.12.2-canary.1738.21388.0
yarn add @auto-canary/auto@10.12.2-canary.1738.21388.0
yarn add @auto-canary/core@10.12.2-canary.1738.21388.0
yarn add @auto-canary/package-json-utils@10.12.2-canary.1738.21388.0
yarn add @auto-canary/all-contributors@10.12.2-canary.1738.21388.0
yarn add @auto-canary/brew@10.12.2-canary.1738.21388.0
yarn add @auto-canary/chrome@10.12.2-canary.1738.21388.0
yarn add @auto-canary/cocoapods@10.12.2-canary.1738.21388.0
yarn add @auto-canary/conventional-commits@10.12.2-canary.1738.21388.0
yarn add @auto-canary/crates@10.12.2-canary.1738.21388.0
yarn add @auto-canary/docker@10.12.2-canary.1738.21388.0
yarn add @auto-canary/exec@10.12.2-canary.1738.21388.0
yarn add @auto-canary/first-time-contributor@10.12.2-canary.1738.21388.0
yarn add @auto-canary/gem@10.12.2-canary.1738.21388.0
yarn add @auto-canary/gh-pages@10.12.2-canary.1738.21388.0
yarn add @auto-canary/git-tag@10.12.2-canary.1738.21388.0
yarn add @auto-canary/gradle@10.12.2-canary.1738.21388.0
yarn add @auto-canary/jira@10.12.2-canary.1738.21388.0
yarn add @auto-canary/maven@10.12.2-canary.1738.21388.0
yarn add @auto-canary/microsoft-teams@10.12.2-canary.1738.21388.0
yarn add @auto-canary/npm@10.12.2-canary.1738.21388.0
yarn add @auto-canary/omit-commits@10.12.2-canary.1738.21388.0
yarn add @auto-canary/omit-release-notes@10.12.2-canary.1738.21388.0
yarn add @auto-canary/pr-body-labels@10.12.2-canary.1738.21388.0
yarn add @auto-canary/released@10.12.2-canary.1738.21388.0
yarn add @auto-canary/s3@10.12.2-canary.1738.21388.0
yarn add @auto-canary/slack@10.12.2-canary.1738.21388.0
yarn add @auto-canary/twitter@10.12.2-canary.1738.21388.0
yarn add @auto-canary/upload-assets@10.12.2-canary.1738.21388.0
yarn add @auto-canary/vscode@10.12.2-canary.1738.21388.0

@adierkens adierkens added the patch Increment the patch version when merged label Jan 21, 2021
@codecov
Copy link

codecov bot commented Jan 21, 2021

Codecov Report

Merging #1738 (1f96b1e) into main (be24135) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1738      +/-   ##
==========================================
+ Coverage   80.19%   80.22%   +0.03%     
==========================================
  Files          63       63              
  Lines        4898     4901       +3     
  Branches     1120     1120              
==========================================
+ Hits         3928     3932       +4     
  Misses        666      666              
+ Partials      304      303       -1     
Impacted Files Coverage Δ
packages/core/src/auto.ts 78.11% <100.00%> (+0.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be24135...1f96b1e. Read the comment docs.

@hipstersmoothie hipstersmoothie merged commit 317937f into main Jan 21, 2021
@hipstersmoothie hipstersmoothie deleted the next-skip branch January 21, 2021 22:36
@adierkens
Copy link
Collaborator

🚀 PR was released in v10.12.1 🚀

@adierkens adierkens added the released This issue/pull request has been released. label Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Question about merging a PR in a pre-release branch
2 participants