Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loading object author from auto rc #2172

Merged
merged 1 commit into from
Mar 20, 2022
Merged

Conversation

hipstersmoothie
Copy link
Collaborator

@hipstersmoothie hipstersmoothie commented Mar 20, 2022

Tested that it loads the config author on a local project.

Fixes #2140

🐤 Download canary assets:

auto-linux--canary.2172.25820.gz
auto-macos--canary.2172.25820.gz
auto-win.exe--canary.2172.25820.gz

📦 Published PR as canary version: under canary scope @auto-canary@10.36.1--canary.2172.25820.0

✨ Test out this PR locally via:

npm install @auto-canary/bot-list@10.36.1--canary.2172.25820.0
npm install @auto-canary/auto@10.36.1--canary.2172.25820.0
npm install @auto-canary/core@10.36.1--canary.2172.25820.0
npm install @auto-canary/package-json-utils@10.36.1--canary.2172.25820.0
npm install @auto-canary/all-contributors@10.36.1--canary.2172.25820.0
npm install @auto-canary/brew@10.36.1--canary.2172.25820.0
npm install @auto-canary/chrome@10.36.1--canary.2172.25820.0
npm install @auto-canary/cocoapods@10.36.1--canary.2172.25820.0
npm install @auto-canary/conventional-commits@10.36.1--canary.2172.25820.0
npm install @auto-canary/crates@10.36.1--canary.2172.25820.0
npm install @auto-canary/docker@10.36.1--canary.2172.25820.0
npm install @auto-canary/exec@10.36.1--canary.2172.25820.0
npm install @auto-canary/first-time-contributor@10.36.1--canary.2172.25820.0
npm install @auto-canary/gem@10.36.1--canary.2172.25820.0
npm install @auto-canary/gh-pages@10.36.1--canary.2172.25820.0
npm install @auto-canary/git-tag@10.36.1--canary.2172.25820.0
npm install @auto-canary/gradle@10.36.1--canary.2172.25820.0
npm install @auto-canary/jira@10.36.1--canary.2172.25820.0
npm install @auto-canary/magic-zero@10.36.1--canary.2172.25820.0
npm install @auto-canary/maven@10.36.1--canary.2172.25820.0
npm install @auto-canary/microsoft-teams@10.36.1--canary.2172.25820.0
npm install @auto-canary/npm@10.36.1--canary.2172.25820.0
npm install @auto-canary/omit-commits@10.36.1--canary.2172.25820.0
npm install @auto-canary/omit-release-notes@10.36.1--canary.2172.25820.0
npm install @auto-canary/pr-body-labels@10.36.1--canary.2172.25820.0
npm install @auto-canary/released@10.36.1--canary.2172.25820.0
npm install @auto-canary/s3@10.36.1--canary.2172.25820.0
npm install @auto-canary/sbt@10.36.1--canary.2172.25820.0
npm install @auto-canary/slack@10.36.1--canary.2172.25820.0
npm install @auto-canary/twitter@10.36.1--canary.2172.25820.0
npm install @auto-canary/upload-assets@10.36.1--canary.2172.25820.0
npm install @auto-canary/vscode@10.36.1--canary.2172.25820.0
# or 
yarn add @auto-canary/bot-list@10.36.1--canary.2172.25820.0
yarn add @auto-canary/auto@10.36.1--canary.2172.25820.0
yarn add @auto-canary/core@10.36.1--canary.2172.25820.0
yarn add @auto-canary/package-json-utils@10.36.1--canary.2172.25820.0
yarn add @auto-canary/all-contributors@10.36.1--canary.2172.25820.0
yarn add @auto-canary/brew@10.36.1--canary.2172.25820.0
yarn add @auto-canary/chrome@10.36.1--canary.2172.25820.0
yarn add @auto-canary/cocoapods@10.36.1--canary.2172.25820.0
yarn add @auto-canary/conventional-commits@10.36.1--canary.2172.25820.0
yarn add @auto-canary/crates@10.36.1--canary.2172.25820.0
yarn add @auto-canary/docker@10.36.1--canary.2172.25820.0
yarn add @auto-canary/exec@10.36.1--canary.2172.25820.0
yarn add @auto-canary/first-time-contributor@10.36.1--canary.2172.25820.0
yarn add @auto-canary/gem@10.36.1--canary.2172.25820.0
yarn add @auto-canary/gh-pages@10.36.1--canary.2172.25820.0
yarn add @auto-canary/git-tag@10.36.1--canary.2172.25820.0
yarn add @auto-canary/gradle@10.36.1--canary.2172.25820.0
yarn add @auto-canary/jira@10.36.1--canary.2172.25820.0
yarn add @auto-canary/magic-zero@10.36.1--canary.2172.25820.0
yarn add @auto-canary/maven@10.36.1--canary.2172.25820.0
yarn add @auto-canary/microsoft-teams@10.36.1--canary.2172.25820.0
yarn add @auto-canary/npm@10.36.1--canary.2172.25820.0
yarn add @auto-canary/omit-commits@10.36.1--canary.2172.25820.0
yarn add @auto-canary/omit-release-notes@10.36.1--canary.2172.25820.0
yarn add @auto-canary/pr-body-labels@10.36.1--canary.2172.25820.0
yarn add @auto-canary/released@10.36.1--canary.2172.25820.0
yarn add @auto-canary/s3@10.36.1--canary.2172.25820.0
yarn add @auto-canary/sbt@10.36.1--canary.2172.25820.0
yarn add @auto-canary/slack@10.36.1--canary.2172.25820.0
yarn add @auto-canary/twitter@10.36.1--canary.2172.25820.0
yarn add @auto-canary/upload-assets@10.36.1--canary.2172.25820.0
yarn add @auto-canary/vscode@10.36.1--canary.2172.25820.0

@hipstersmoothie hipstersmoothie added the patch Increment the patch version when merged label Mar 20, 2022
@codecov
Copy link

codecov bot commented Mar 20, 2022

Codecov Report

Merging #2172 (5b54ef4) into main (34d4450) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2172   +/-   ##
=======================================
  Coverage   80.37%   80.37%           
=======================================
  Files          66       66           
  Lines        5427     5427           
  Branches     1272     1272           
=======================================
  Hits         4362     4362           
  Misses        706      706           
  Partials      359      359           
Impacted Files Coverage Δ
packages/core/src/types.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34d4450...5b54ef4. Read the comment docs.

@hipstersmoothie hipstersmoothie merged commit fda030a into main Mar 20, 2022
@hipstersmoothie hipstersmoothie deleted the object-author-rc branch March 20, 2022 19:25
@intuit-svc
Copy link

🚀 PR was released in v10.36.1 🚀

@intuit-svc intuit-svc added the released This issue/pull request has been released. label Mar 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

doesnt work with "author" described as an object
2 participants