fix(npm): mark releases as latest with lerna #2414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@intuit any chance to get it merged? Having same problem causing incorrect change logs and version numbers |
This was referenced Feb 21, 2024
jazmon
force-pushed
the
fix-latest-release-lerna-monorepo
branch
from
281b903
to
50e3b29
Compare
Co-authored-by: Jack Westbrook <jack.westbrook@gmail.com>
jazmon
force-pushed
the
fix-latest-release-lerna-monorepo
branch
from
50e3b29
to
a55aac0
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2414 +/- ##
==========================================
- Coverage 80.65% 80.57% -0.09%
==========================================
Files 69 69
Lines 5676 5677 +1
Branches 1274 1275 +1
==========================================
- Hits 4578 4574 -4
- Misses 718 719 +1
- Partials 380 384 +4 ☔ View full report in Codecov by Sentry. |
|
Looks like it's passing the CI checks! (other than the two that seem to have some other issues) Anything preventing from releasing this? |
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed
Mark the releases as "latest" when releasing with the npm plugin with the independent mode.
Why
Currently
autogets the latest release by looking for a release that is marked as "latest". Thenpmplugin does not update the "latest" tag when releasing with independent mode causing the releases to start diffing from the initial release.Todo:
Change Type
Indicate the type of change your pull request is:
documentationpatchminormajor