Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: next version calculation for tags that contain a name/prefix #2436

Merged
merged 4 commits into from
Feb 24, 2024
Merged

fix: next version calculation for tags that contain a name/prefix #2436

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6378457
fix: make this work for tags that contain a name/prefix before the ve…
restfulhead Feb 23, 2024
210391a
test: for changelog based on tags with names
restfulhead Feb 23, 2024
820e33a
fix: test names
restfulhead Feb 23, 2024
fcad699
test: improve assertion
restfulhead Feb 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/core/src/release.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,7 +423,9 @@ export default class Release {
/** Given a tag get the next incremented version */
async calcNextVersion(lastTag: string) {
const bump = await this.getSemverBump(lastTag);
return inc(lastTag, bump as ReleaseType);
const matches = lastTag.match(/(\d+\.\d+\.\d+)/)
const lastVersion = matches ? matches[0] : lastTag
return inc(lastVersion, bump as ReleaseType);
}

/** Create the class that will parse the log for PR info */
Expand Down