Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

canary: try to match commit to PR if not found in env #812

Merged
merged 1 commit into from
Jan 21, 2020

Conversation

hipstersmoothie
Copy link
Collaborator

@hipstersmoothie hipstersmoothie commented Dec 16, 2019

What Changed

If we can't find pr in env info, use github api to match commit to PR.

Why

closes #481

@glambert could you test this version out for me and see if it now works as intended?

Published PR with canary version:

Published under canary scope @auto-canary

  • @auto-canary/auto@8.4.2-canary.812.10761.0
  • @auto-canary/core@8.4.2-canary.812.10761.0
  • @auto-canary/all-contributors@8.4.2-canary.812.10761.0
  • @auto-canary/chrome@8.4.2-canary.812.10761.0
  • @auto-canary/conventional-commits@8.4.2-canary.812.10761.0
  • @auto-canary/crates@8.4.2-canary.812.10761.0
  • @auto-canary/first-time-contributor@8.4.2-canary.812.10761.0
  • @auto-canary/git-tag@8.4.2-canary.812.10761.0
  • @auto-canary/jira@8.4.2-canary.812.10761.0
  • @auto-canary/maven@8.4.2-canary.812.10761.0
  • @auto-canary/npm@8.4.2-canary.812.10761.0
  • @auto-canary/omit-commits@8.4.2-canary.812.10761.0
  • @auto-canary/omit-release-notes@8.4.2-canary.812.10761.0
  • @auto-canary/released@8.4.2-canary.812.10761.0
  • @auto-canary/s3@8.4.2-canary.812.10761.0
  • @auto-canary/slack@8.4.2-canary.812.10761.0
  • @auto-canary/twitter@8.4.2-canary.812.10761.0
  • @auto-canary/upload-assets@8.4.2-canary.812.10761.0

@hipstersmoothie hipstersmoothie added the patch Increment the patch version when merged label Dec 16, 2019
@codecov
Copy link

codecov bot commented Dec 16, 2019

Codecov Report

Merging #812 into master will decrease coverage by 0.21%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #812      +/-   ##
==========================================
- Coverage   86.15%   85.93%   -0.22%     
==========================================
  Files          36       37       +1     
  Lines        2354     2367      +13     
  Branches      293      298       +5     
==========================================
+ Hits         2028     2034       +6     
- Misses        262      268       +6     
- Partials       64       65       +1
Impacted Files Coverage Δ
packages/core/src/release.ts 95.87% <100%> (+0.09%) ⬆️
packages/core/src/auto.ts 86.74% <50%> (-1.28%) ⬇️
packages/core/src/match-sha-to-pr.ts 95.23% <95.23%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cfe606...2077126. Read the comment docs.

@glambert
Copy link

@glambert
Copy link

Am I missing something on how to install canary releases? 😉

https://github.com/glambert/auto-lerna-independent-poc/pull/6/checks?check_run_id=351567733#step:6:11

@hipstersmoothie
Copy link
Collaborator Author

Nah you just found a bug 😓

@glambert
Copy link

glambert commented Dec 16, 2019

Btw caching for yarn should not be done with node_modules folder if I recall, see: https://github.com/glambert/auto-lerna-independent-poc/pull/6/commits/81d7870ac4f13c169e6b5fb0a064dff0ae030fb4. This is the strategy we've been using for all our workflows. I remember trying to cache node_modules and it was giving me mixed results.

See https://help.github.com/en/actions/automating-your-workflow-with-github-actions/caching-dependencies-to-speed-up-workflows#example-using-the-cache-action as well.

@hipstersmoothie hipstersmoothie added minor Increment the minor version when merged and removed patch Increment the patch version when merged labels Jan 21, 2020
@hipstersmoothie hipstersmoothie merged commit 1d7afd6 into master Jan 21, 2020
@hipstersmoothie hipstersmoothie deleted the canary-action branch January 21, 2020 19:43
@adierkens
Copy link
Collaborator

🚀 PR was released in v9.1.0 🚀

@adierkens adierkens added the released This issue/pull request has been released. label Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Increment the minor version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Canary version not being added to some PRs in GitHub Action
3 participants