Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly add npm & yarn step for all-contributors #895

Merged
merged 1 commit into from
Jan 25, 2020

Conversation

ericclemmons
Copy link
Contributor

What Changed

Prefer npm or yarn over npx install-peerdeps.

Why

After prompting to use yarn or not (y/n), install-peerdeps only exited. node_modules nor package.json changed.

Since the purpose is to install both packages together, I listed them explicitly.

It's a great tool & idea (especially if there's concern in all-contributors-cli becoming incompatible with the plugin), but I couldn't continue the setup in https://github.com/ericclemmons/codelift/pull/78 otherwise.

install-peerdeps wasn't installing anything after prompting to use yarn
or not
@hipstersmoothie hipstersmoothie added the documentation Changes only affect the documentation label Jan 25, 2020
@codecov
Copy link

codecov bot commented Jan 25, 2020

Codecov Report

Merging #895 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #895   +/-   ##
=======================================
  Coverage   84.51%   84.51%           
=======================================
  Files          39       39           
  Lines        2467     2467           
  Branches      316      316           
=======================================
  Hits         2085     2085           
  Misses        300      300           
  Partials       82       82

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aed2420...364eecf. Read the comment docs.

@hipstersmoothie hipstersmoothie merged commit 11fec26 into intuit:master Jan 25, 2020
@adierkens
Copy link
Collaborator

🚀 PR was released in v9.3.3 🚀

@adierkens adierkens added the released This issue/pull request has been released. label Jan 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Changes only affect the documentation released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants