Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 📦 emoji to canary PR message to make it more noticeable #897

Merged
merged 1 commit into from
Jan 25, 2020

Conversation

ericclemmons
Copy link
Contributor

@ericclemmons ericclemmons commented Jan 25, 2020

What Changed

Published PR with canary version: 0.5.1-canary.58.fea0a94.0

becomes

📦 Published PR as canary version: 0.5.1-canary.58.fea0a94.0

Why

When adding auto to codelift I didn't even realize that this message was added to the PR body. (Was expecting a comment or something in the GitHub check to appear).

In retrospect, this is a good place to keep it so that (1) it doesn't create noise in the thread and (2) users who visit a PR can immediately see how to test it.

There is some opportunity to potentially make it look like the following, but it would require knowledge of npm or yarn being used to publish:

📦 Published PR as canary version: 0.5.1-canary.58.fea0a94.0

Test out this PR locally via:

npm install codelift@0.5.1-canary.58.fea0a94.0
# or 
yarn add codelift@0.5.1-canary.58.fea0a94.0

@hipstersmoothie hipstersmoothie added the patch Increment the patch version when merged label Jan 25, 2020
@hipstersmoothie
Copy link
Collaborator

I'll add the install instructions in another PR. thanks for the idea!

@codecov
Copy link

codecov bot commented Jan 25, 2020

Codecov Report

Merging #897 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #897   +/-   ##
=======================================
  Coverage   84.51%   84.51%           
=======================================
  Files          39       39           
  Lines        2467     2467           
  Branches      316      344   +28     
=======================================
  Hits         2085     2085           
  Misses        300      300           
  Partials       82       82
Impacted Files Coverage Δ
packages/core/src/auto.ts 83.4% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aed2420...8292771. Read the comment docs.

@hipstersmoothie hipstersmoothie merged commit c435a61 into intuit:master Jan 25, 2020
@adierkens
Copy link
Collaborator

🚀 PR was released in v9.3.3 🚀

@adierkens adierkens added the released This issue/pull request has been released. label Jan 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants