-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate from Arrow Meta to Kotlin Symbol Processor #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@stabbylambda would love your opinion on the new annotation-based DSL (comes from restraints of KSP over Arrow Meta) |
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed
Migrate to KSP (also includes Kotlin 1.6+ upgrade and Gradle version catalog update)
Why
#16
Concerns
Assignment based -> Annotation based.
hooks/example-library/src/main/kotlin/com/intuit/hooks/example/library/generic/GenericHooks.kt
Lines 7 to 19 in 0115548
Still would like to migrate to Kotlin poet as well!
Gradle/Maven plugins wrappers tie to a specific version of KSP/Kotlin -- so if we keep those, we should release those independently to align with KSP/Kotlin version
Ktlint is incompatible with Maven :(
Resolutions
Postponing for another PR
Will release in accordance with hooks for now with explicit documentation regarding what Kotlin version it is compatible with. In the future, we will fix publishing to publish against proper versions (for 1.0)
Swapping to Kotlin poet should help with proper formatting anyways
📦 Published PR as canary version:
0.11.2-canary.24.249-SNAPSHOT
Release Notes
💥 This is a breaking change 💥
Migration to KSP from Arrow Meta because they dropped support for source generation. This does improve the overall maturity of the codegen module (
compiler-plugin
->processor
). However, the KSP framework doesn't support the code typing introspection that we were doing in Arrow Meta. Instead, we have to rely strictly on typings and annotations, which changes the DSL we originally had.