Addressed some of the further comments...

intuit · Jun 19, 2017 · 4009518 · 4009518
1 parent 36fa05a
commit 4009518
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/modules/experiment/src/main/java/com/intuit/wasabi/experiment/impl/ExperimentsImpl.java b/modules/experiment/src/main/java/com/intuit/wasabi/experiment/impl/ExperimentsImpl.java
@@ -152,7 +152,9 @@ public void createExperiment(NewExperiment newExperiment, UserInfo user) {
         validator.validateNewExperiment(newExperiment);
         try {
 
-            //Step#2: Create experiment in MySQL
+            //Step#2: Create experiment in MySQL first (before Cassandra) so that duplicate experiment
+            //concern would be addressed automatically. As, AppName and experiment label have a unique constraint
+            //set in MySQL table.
             LOGGER.debug("Creating an experiment in MySQL...");
             databaseRepository.createExperiment(newExperiment);
 

diff --git a/.../main/java/com/intuit/wasabi/repository/cassandra/impl/CassandraExperimentRepository.java b/.../main/java/com/intuit/wasabi/repository/cassandra/impl/CassandraExperimentRepository.java
@@ -98,6 +98,7 @@ public class CassandraExperimentRepository implements ExperimentRepository {
 
     private ExperimentTagAccessor experimentTagAccessor;
 
+    //@TODO This and other accessors can be declared final as/if they are being Injected in constructor using guice.
     private PrioritiesAccessor prioritiesAccessor;
 
     /**