-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/failsafe retry : Exponential backoff based retry mechanism for assignment export #240
Conversation
@@ -93,4 +93,34 @@ public Boolean useProxy() { | |||
public int getRetries() { | |||
return Integer.parseInt((String) properties.get("export.rest.retries")); | |||
} | |||
|
|||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job with Javadoc here! 👍
@@ -17,11 +17,13 @@ | |||
|
|||
import com.google.inject.Inject; | |||
import com.intuit.wasabi.export.rest.RestEndPoint; | |||
import net.jodah.failsafe.RetryPolicy; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome to reuse an existing open source library for this use case!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job incorporating an existing open source library! 👍
@abhishekjain88 Looks good! Is it being used by wasabi-intuit's Trinity and Omniture? |
@jcwuzoegiver Yes, exactly. There is a corresponding PR in wasabi-intuit. |
No description provided.