Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ab-simulation contribution #258

Merged
merged 2 commits into from Jun 19, 2017
Merged

ab-simulation contribution #258

merged 2 commits into from Jun 19, 2017

Conversation

dillard
Copy link
Contributor

@dillard dillard commented Jun 15, 2017

code used for AB testing meetup presentation

@coveralls
Copy link

Coverage Status

Coverage remained the same at 75.908% when pulling 81f75f5 on ab-simulation into 48d6f97 on master.

@@ -0,0 +1,187 @@
# A Python 2.7 library to simulate AB tests and analyze results.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dillard Please add the copyright header to the python script as this is in the open source repo

###############################################################################
# Copyright 2016 Intuit
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
#     http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
###############################################################################```

@iizrailevsky
Copy link
Member

Looks good. :shipit: provided that the copyright header is included

@dillard dillard changed the title Initial public commit. ab-simulation contribution Jun 19, 2017
@dillard dillard merged commit 5c6ca56 into master Jun 19, 2017
@dillard dillard deleted the ab-simulation branch June 19, 2017 22:49
@coveralls
Copy link

Coverage Status

Coverage remained the same at 75.908% when pulling 8573744 on ab-simulation into 48d6f97 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants