Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jzintv Keyboard Hackfile path not working? #204

Closed
intvsteve opened this Issue Jun 22, 2018 · 2 comments

Comments

1 participant
@intvsteve
Copy link
Owner

intvsteve commented Jun 22, 2018

Operating system version

macOS 10.10.5

Program version (from About box)

1.0.0.2910

Expected behavior

Keyboard hack file is used

Actual behavior

It is not

Steps to reproduce

Try a custom keyboard hackfile.

Workaround

Add --kbdhackfile argument manually.

@intvsteve intvsteve self-assigned this Jun 22, 2018

@intvsteve intvsteve added the bug label Jun 22, 2018

@intvsteve intvsteve added this to New Bugs in Bug Fixes via automation Jun 23, 2018

@intvsteve

This comment has been minimized.

Copy link
Owner Author

intvsteve commented Jun 30, 2018

In this case, but is Mac-specific. The paths to various files as stored in preferences are using NSUrl data. Before any path-related setting for jzintv is sent, however, the UI validates it.

Problem was that the C# System.IO.Path APIs operate on path strings, not "Uri" strings -- the necessary conversion from file:// syntax to file system path syntax was missing.

@intvsteve

This comment has been minimized.

Copy link
Owner Author

intvsteve commented Jun 30, 2018

Furthermore, found that some other paths aside from hackfile were affected, though they are not presently exposed in the UI. Up to two CGC adapters are supported. The CGC configuration isn't exposed since it's untested, and may be unsupported in Windows versions newer than Windows xp anyway due to driver issues.

intvsteve added a commit that referenced this issue Aug 19, 2018

Fix issue #203 and issue #204
Issue #203 is ECS.bin is not always passed to jzintv. LUI was only doing this when -s1 was needed based on ROM features and user settings. Change is to always send the -E /ecs/path/ECS.bin to jzintv since jzintv will only really care to load it if -s1 is also sent.

Custom command line setting in the case where this bug was found was including -s1 for all ROMs - which exposed the interaction between the two args.

For Issue #204, code had overlooked that settings data stores path strings as NSUrl data on Mac, so a 'resolve' is needed for the C# System.IO.Path validation code to work properly. Due to that oversight, hackfiles could *never* work on Mac because the validation code would never find files with paths that had URI syntax (file:///path/to/hackfile.txt).

Bug Fixes automation moved this from New Bugs to Fixed Bugs Aug 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.