Skip to content

Commit

Permalink
Add name repeater normalizer
Browse files Browse the repository at this point in the history
Closes #98
  • Loading branch information
inukshuk committed May 29, 2018
1 parent e268f50 commit e07f243
Show file tree
Hide file tree
Showing 2 changed files with 34 additions and 8 deletions.
27 changes: 19 additions & 8 deletions lib/anystyle/normalizer/names.rb
Expand Up @@ -9,8 +9,8 @@ class Names < Normalizer

attr_accessor :namae

def initialize(**options)
super(**options)
def initialize(**opts)
super(**opts)

@namae = Namae::Parser.new({
prefer_comma_as_separator: true,
Expand All @@ -20,16 +20,26 @@ def initialize(**options)
})
end

def normalize(item, **opts)
map_values(item) do |_, value|
begin
parse(strip(value))
rescue
[{ literal: value }]
def normalize(item, prev: [], **opts)
map_values(item) do |key, value|
value.gsub!(/(^[\(\[]|[,;:\)\]]+$)/, '')
case
when repeater?(value) && prev.length > 0
prev[-1][key][0] || prev[1][:author][0]
else
begin
parse(strip(value))
rescue
[{ literal: value }]
end
end
end
end

def repeater?(value)
value =~ /^[\p{P}\s]+$/
end

def strip(value)
value
.gsub(/^[Ii]n:?\s+/, '')
Expand All @@ -43,6 +53,7 @@ def strip(value)
.gsub(/\b([Pp]rod(\.|uce[rd]))(\s+by)?\s+/, '')
.gsub(/\b([Pp]erf(\.|orme[rd]))(\s+by)?\s+/, '')
.gsub(/\([^\)]*\)/, '')
.gsub(/^\p{P}+\s/, '')
.gsub(/[;:]/, ',')
.strip
end
Expand Down
15 changes: 15 additions & 0 deletions spec/anystyle/normalizer/names_spec.rb
@@ -0,0 +1,15 @@
module AnyStyle
describe Normalizer::Names do
let(:n) { Normalizer::Names.new }

let(:item) {{
author: [names(:derrida)]
}}

it "resolves repeaters" do
expect(
n.normalize({ author: ['-----.,'] }, prev: [n.normalize(item)])[:author][0]
).to include(family: 'Derrida')
end
end
end

0 comments on commit e07f243

Please sign in to comment.