Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the 'numbering' option in the configuration for unordered publicat... #62

Merged
merged 2 commits into from
Oct 30, 2014

Conversation

lianne
Copy link
Contributor

@lianne lianne commented Oct 28, 2014

I thought it would be useful to have a configuration option for jekyll-scholar so that the publication list is not numbered.
I modified the 'bibliography.rb' file so that, if the _config.yml file for the jekyll site has an option numbering : false, then the list will be unordered (ul), otherwise it will be the standard ordered (ol) list.

_config_yml

@inukshuk
Copy link
Owner

How about we add a bibliography_tag option (which defaults to 'ol') and a bibliography_item_tag (which defaults to 'li') and use those instead? This would provide more flexibility and we would not need if-else branches but feed the tag name directly to content_tag. What do you think? Could you adjust the pull request like this?

@inukshuk
Copy link
Owner

Also, new options must be added to defaults.rb -- otherwise it's hard to keep track of what options there are.

…ography_item_tag' have been introduced. Defaults.rb has been updated.
@lianne
Copy link
Contributor Author

lianne commented Oct 29, 2014

It makes sense!!
Indeed I added the options 'bibliography_list_tag' => 'ol', and 'bibliography_item_tag' => 'li', to defaults.rb and I modified bibliography.rb accordingly. I pushed my last commit.

inukshuk added a commit that referenced this pull request Oct 30, 2014
Added the 'numbering' option in the configuration for unordered publicat...
@inukshuk inukshuk merged commit 6592f3b into inukshuk:master Oct 30, 2014
@inukshuk
Copy link
Owner

Landed in 4.1.2.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants