You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Dec 10, 2020. It is now read-only.
The current implementations for backsolving in generic.jl and trmm / trsm in blas.jl are sub-optimal. Certain quantities that do not need to be recomputed are being recomputed. In the situation that the gradient w.r.t. both (matrix-valued) arguments is requested, the recomputed quantity is actually the sensitivity w.r.t. one of the arguments, thus this optimisation is strictly better than the current implementation in such scenarios.
The solution to this is conceptually straightforward, and we even have part of the infrastructure required to make this work sorted (the currently unused third argument to the sensitivities).
The text was updated successfully, but these errors were encountered:
The current implementations for backsolving in generic.jl and trmm / trsm in blas.jl are sub-optimal. Certain quantities that do not need to be recomputed are being recomputed. In the situation that the gradient w.r.t. both (matrix-valued) arguments is requested, the recomputed quantity is actually the sensitivity w.r.t. one of the arguments, thus this optimisation is strictly better than the current implementation in such scenarios.
The solution to this is conceptually straightforward, and we even have part of the infrastructure required to make this work sorted (the currently unused third argument to the sensitivities).
The text was updated successfully, but these errors were encountered: