This repository has been archived by the owner on Feb 11, 2021. It is now read-only.
ResultTypes minimum bound #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… use v2.0.0 ``` ERROR: Unsatisfiable requirements detected for package ResultTypes: ... ├─version range [2.0.0,∞) required by package MyPkg, whose only allowed version is 0.2.0+: │ └─version 0.2.0+ set by fixed requirement (package is checked out, dirty or pinned) └─version range [0.1.0,2.0.0) required by package Dispatcher, whose allowed version range is [0.0.0-,∞): The intersection of the requirements is empty. ``` I'm not sure why the default version range was [0.1.0,2.0.0) though :/
rofinn
changed the title
iamed2
approved these changes
May 31, 2018
Codecov Report
@@ Coverage Diff @@
## master #37 +/- ##
=======================================
Coverage 82.29% 82.29%
=======================================
Files 4 4
Lines 305 305
=======================================
Hits 251 251
Misses 54 54Continue to review full report at Codecov.
|
iamed2
reviewed
May 31, 2018
test/runtests.jl
Outdated
| @@ -3,9 +3,12 @@ using ResultTypes | |||
| using Base.Test | |||
| using Memento | |||
| using IterTools | |||
| import Compat: @__MODULE__ | |||
| using Compat | |||
There was a problem hiding this comment.
Please revert this change (or change to using Compat: @__MODULE__)
rofinn
force-pushed
the
rf/resulttypes-minbound
branch
from
957ce78
to
8d93375
Compare
iamed2
approved these changes
May 31, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically, the issue I was getting is:
I'm not sure why the default version range was [0.1.0,2.0.0) though :/