Appveyor only tests plotting #115
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #115 +/- ##
=======================================
Coverage 73.50% 73.50%
=======================================
Files 8 8
Lines 400 400
=======================================
Hits 294 294
Misses 106 106 Continue to review full report at Codecov.
|
|
Looks like I have a CI issue to sort out and I need to report on the speed improvements |
|
This is obsolete, right? |
Yes, this is pretty outdated but limiting where we test plotting is still a consideration. I'll try and validate the performance is bad enough that this kind of change is still needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've updated the CI testing so that Appveyor only does plotting testing on Windows and Travis CI does the remainder of the Windows tests. Ideally this should decrease overall CI time. Note there is currently a bug with FFMPEG.jl and Trvais CI which means we cannot test plotting on Windows in Travis CI.
Additionally, the ability to restrict what tests are run is generally useful and I would have used that with the recent addition of unbounded intervals.