Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add inclusivity default info to the docstrings for HourEnding and HourBeginning #138

Merged
merged 2 commits into from
Aug 19, 2020

Conversation

mzgubic
Copy link
Contributor

@mzgubic mzgubic commented Aug 14, 2020

Closes #77

@mzgubic mzgubic requested a review from omus as a code owner August 14, 2020 10:32
@codecov
Copy link

codecov bot commented Aug 14, 2020

Codecov Report

Merging #138 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #138   +/-   ##
=======================================
  Coverage   74.23%   74.23%           
=======================================
  Files          10       10           
  Lines         458      458           
=======================================
  Hits          340      340           
  Misses        118      118           
Impacted Files Coverage Δ
src/anchoredinterval.jl 96.15% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7a27c3...282676f. Read the comment docs.

Copy link
Collaborator

@omus omus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the addition but it needed some additional clarification. Let me know if these make sense to you

src/anchoredinterval.jl Outdated Show resolved Hide resolved
src/anchoredinterval.jl Outdated Show resolved Hide resolved
Co-authored-by: Curtis Vogt <curtis.vogt@gmail.com>
@mzgubic
Copy link
Contributor Author

mzgubic commented Aug 17, 2020

I like the addition but it needed some additional clarification. Let me know if these make sense to you

Thanks for the review, yes it is much clearer this way.

@mzgubic mzgubic merged commit bfa3ea8 into master Aug 19, 2020
@mzgubic mzgubic deleted the mz/docs branch August 19, 2020 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add to docstrings HourEnding and HourBegining have default inclusivity
2 participants