WIP: Revisit (less|greater)_than_disjoint functions
#45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
iamed2
requested changes
Jul 17, 2018
| return LeftEndpoint(a) < LeftEndpoint(b) | ||
| end | ||
|
|
||
| function less_than_disjoint(a::AbstractInterval, b::AbstractInterval) | ||
| isless_disjoint(a::AbstractInterval, b) = RightEndpoint(a) < b |
There was a problem hiding this comment.
If it's called isless-something it should call isless, not <.
There was a problem hiding this comment.
Good point. I need to some investigation here.
Codecov Report
@@ Coverage Diff @@
## master #45 +/- ##
==========================================
- Coverage 98.07% 98.06% -0.01%
==========================================
Files 6 6
Lines 208 207 -1
==========================================
- Hits 204 203 -1
Misses 4 4
Continue to review full report at Codecov.
|
|
I have some additional ideas regarding |
omus
changed the title
(less|greater)_than_disjoint functions(less|greater)_than_disjoint functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes suggested by @ararslan (#42 (comment)).