Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for mixtures #40

Merged
merged 24 commits into from
Dec 22, 2022
Merged

Add support for mixtures #40

merged 24 commits into from
Dec 22, 2022

Conversation

aisopous
Copy link
Contributor

@aisopous aisopous commented Nov 2, 2022

Implements constructors and marginalisation for Distributions.MixtureModel, and a UnionAll type KeyedMixtureModel

#5

src/KeyedDistributions.jl Outdated Show resolved Hide resolved
src/KeyedDistributions.jl Outdated Show resolved Hide resolved
src/KeyedDistributions.jl Outdated Show resolved Hide resolved
src/KeyedDistributions.jl Outdated Show resolved Hide resolved
src/KeyedDistributions.jl Outdated Show resolved Hide resolved
src/KeyedDistributions.jl Outdated Show resolved Hide resolved
src/KeyedDistributions.jl Outdated Show resolved Hide resolved
src/KeyedDistributions.jl Outdated Show resolved Hide resolved
Copy link
Member

@oxinabox oxinabox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clean up any remaining issues and merge when happy

src/KeyedDistributions.jl Outdated Show resolved Hide resolved
aisopous and others added 5 commits December 19, 2022 14:52
Naming convention for Union type

Co-authored-by: Frames Catherine White <oxinabox@ucc.asn.au>
@codecov
Copy link

codecov bot commented Dec 19, 2022

Codecov Report

Merging #40 (4f97a67) into main (0d8a52d) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #40   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           95       128   +33     
=========================================
+ Hits            95       128   +33     
Impacted Files Coverage Δ
src/KeyedDistributions.jl 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rofinn rofinn self-requested a review December 20, 2022 22:18
Copy link
Member

@rofinn rofinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, this looks good to go.

@rofinn rofinn merged commit 1f77b79 into invenia:main Dec 22, 2022
@mjp98 mjp98 mentioned this pull request Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants