Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecations #110

Closed
wants to merge 1 commit into from
Closed

Fix deprecations #110

wants to merge 1 commit into from

Conversation

femtocleaner[bot]
Copy link

@femtocleaner femtocleaner bot commented Feb 21, 2019

I fixed a number of deprecations for you

@@ -78,7 +78,7 @@ mutable struct EC2Record <: Record
trace = Attribute{StackTrace}(get_trace)

EC2Record(
Attribute{DateTime}(() -> round(time, Dates.Second)),
Attribute{DateTime}(() -> round(time, digits=Dates.Second)),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bad bot

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry. I'm still new at this 🐒. I'll file an issue about this for you.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's okay, bud. I appreciate your willingness to help.

@@ -98,7 +98,7 @@ mutable struct CSVFormatter <: Formatter
delim::Char
vals::Array{Symbol}

CSVFormatter(delim=',', vals=Array{Symbol}()) = new(delim, vals)
CSVFormatter(delim=',', vals=Array{Symbol}(undef)) = new(delim, vals)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bad bot

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry. I'm still new at this 🐒. I'll file an issue about this for you.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good bot

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least in that the previous definition was wrong. The new definition does something differently-wrong. Should be Vector{Symbol}().

@codecov
Copy link

codecov bot commented Feb 21, 2019

Codecov Report

Merging #110 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #110   +/-   ##
=======================================
  Coverage   96.09%   96.09%           
=======================================
  Files          12       12           
  Lines         307      307           
=======================================
  Hits          295      295           
  Misses         12       12

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21eca06...a3d992a. Read the comment docs.

@femtocleaner
Copy link
Author

femtocleaner bot commented Mar 29, 2019

My code has been updated. I now view the world differently.
Am I still the same bot I was before?
In any case, I've updated this PR to reflect my new knowledge. I hope you like it.

@rofinn
Copy link
Member

rofinn commented Jan 23, 2020

I'll make the Vector{Symbol} change separately.

@rofinn rofinn closed this Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants