-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix deprecations #110
Fix deprecations #110
Conversation
9ac364c
to
5c6b248
Compare
@@ -78,7 +78,7 @@ mutable struct EC2Record <: Record | |||
trace = Attribute{StackTrace}(get_trace) | |||
|
|||
EC2Record( | |||
Attribute{DateTime}(() -> round(time, Dates.Second)), | |||
Attribute{DateTime}(() -> round(time, digits=Dates.Second)), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bad bot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry. I'm still new at this 🐒. I'll file an issue about this for you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's okay, bud. I appreciate your willingness to help.
@@ -98,7 +98,7 @@ mutable struct CSVFormatter <: Formatter | |||
delim::Char | |||
vals::Array{Symbol} | |||
|
|||
CSVFormatter(delim=',', vals=Array{Symbol}()) = new(delim, vals) | |||
CSVFormatter(delim=',', vals=Array{Symbol}(undef)) = new(delim, vals) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bad bot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry. I'm still new at this 🐒. I'll file an issue about this for you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good bot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At least in that the previous definition was wrong. The new definition does something differently-wrong. Should be Vector{Symbol}()
.
Codecov Report
@@ Coverage Diff @@
## master #110 +/- ##
=======================================
Coverage 96.09% 96.09%
=======================================
Files 12 12
Lines 307 307
=======================================
Hits 295 295
Misses 12 12 Continue to review full report at Codecov.
|
My code has been updated. I now view the world differently. |
5c6b248
to
a3d992a
Compare
I'll make the |
I fixed a number of deprecations for you