Skip to content
This repository has been archived by the owner on Apr 18, 2023. It is now read-only.

WIP: Use ChainRules for sensitivity definitions #178

Closed
wants to merge 1 commit into from

Conversation

ararslan
Copy link
Collaborator

This is heavily WIP and does not yet pass tests. Using the latest ChainRules master reduces the number of failing tests. I'm opening this PR to give people a sense of what it looks like to use ChainRules inside of Nabla.

@ararslan
Copy link
Collaborator Author

The design here currently is to use the ChainRules rrule if there is one, otherwise we fall back to using our own methods. This has revealed a few oddities (bugs?) with ChainRules, most notably for broadcast; we might need to keep our own broadcasting machinery in Nabla since we specifically define styles for working with Nodes, which ChainRules has no idea about.

@oxinabox
Copy link
Member

Closing in favour of #189

@ararslan ararslan closed this Oct 20, 2020
@ararslan ararslan deleted the aa/chainrules branch October 20, 2020 21:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants