This repository has been archived by the owner on Apr 18, 2023. It is now read-only.
Drop 1.0 #195
Merged
Drop 1.0 #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattBrzezinski
approved these changes
Dec 11, 2020
mjram0s
approved these changes
Dec 11, 2020
omus
approved these changes
Dec 11, 2020
| @@ -1,6 +1,6 @@ | |||
| name = "Nabla" | |||
| uuid = "49c96f43-aa6d-5a04-a506-44c7070ebe78" | |||
| version = "0.12.1" | |||
There was a problem hiding this comment.
dropping Julia 1.0 is not breaking
https://github.com/SciML/ColPrac#dropping-support-for-earlier-versions-of-julia
although ideally it'd be a minor release, so we could back-port things... but we're pre-1.0.0 so we don't have that privilege
There was a problem hiding this comment.
ohh ok. I assumed it was breaking since it completely cuts off versions of julia. my bad
There was a problem hiding this comment.
If we're wrong about this the General registry checks will let us know
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context on why we're dropping 1.0.
This links to the Invenia slack channels, so only people with access will be able to see it.
https://invenia.slack.com/archives/C0259AJLE/p1607448687325200
I believe the consensus is that while using Julia 1.0 we can only use
SpecialFunctions.jlup to version0.8.0, and that version causes a stack overflow in the tests. Newer versions ofSpecialFunctions.jlexist but can only be used for newer versions of Julia.