Merge pull request #214 from KristofferC/kc/eachslice_throw

fix tests on 1.9 where `eachslice` with multiple dimensions are supported
invenia · Mar 3, 2023 · cd36392 · cd36392
2 parents 10a2c7e + 3f5034d
commit cd36392
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 3 deletions.
diff --git a/test/functions.jl b/test/functions.jl
@@ -97,8 +97,21 @@ using Statistics
                 sum(eachslice(a; dims=3)) ==
                 slices[1] + slices[2]
             )
-            @test_throws ArgumentError eachslice(nda; dims=(1, 2))
-            @test_throws ArgumentError eachslice(a; dims=(1, 2))
+
+            supports_eachslice_multidim = 
+                try
+                    eachslice(a; dims=(1, 2))
+                    true
+                catch
+                    false
+                end
+
+            if supports_eachslice_multidim
+                eachslice(nda; dims=(1, 2)) == eachslice(a; dims=(1, 2))
+            else
+                @test_throws ArgumentError eachslice(nda; dims=(1, 2))
+                @test_throws ArgumentError eachslice(a; dims=(1, 2))
+            end
 
             @test_throws UndefKeywordError eachslice(nda)
             @test_throws UndefKeywordError eachslice(a)

diff --git a/test/functions_linearalgebra.jl b/test/functions_linearalgebra.jl
@@ -1,4 +1,3 @@
-using Test: approx_full
 using LinearAlgebra
 using NamedDims
 using NamedDims: dimnames