-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LinearAlgebra: lu, lq, svd, qr #24
Conversation
The same trick can be done for SVD, but it is a bit gross, |
Codecov Report
@@ Coverage Diff @@
## master #24 +/- ##
==========================================
- Coverage 94.79% 94.74% -0.06%
==========================================
Files 11 12 +1
Lines 423 476 +53
==========================================
+ Hits 401 451 +50
- Misses 22 25 +3
Continue to review full report at Codecov.
|
The fact that we often store the dimension names via settign the type of I think it is fine, because LinearAlgegra basically accesses the underlying fields still via Alternative might be to have a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Starting to agree this is a kinda cool idea 😄
# Identity operation should give back original names | ||
@test names(x.Q * x.R) == (:foo, :bar) | ||
|
||
pivot && @testset "pivoted" begin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sneaky! 😹
I should rebase this, and address the comments on the PR. |
@oxinabox If you wanna rebase your branch I can work on addressing the comments. I think making a |
I will rebase this tomorrow then and you can take it over. |
test lu fix LU names
@rofinn done. That was a weirdly hard rebase |
Add linalg factorizations
Alright, now that my changes have been merged back I'm happy to approve, but maybe @nickrobinson251 wants to give it one more look over? |
Should we just merge this as is and then I can update AxisKeys.jl? |
yes? |
Yeah, cause Nick was the original reviewer for this PR. |
Oh sorry I wasn't aware this was waiting on me. I'll take a look tomorrow :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
One question about tests for iterate
(but i might just have missed them)
This will close #12
or at least get closer to it.
Right now I just have
lu!
(which giveslu
anddet
andlogdet
).I thought it might be good the share now to get feedback on the design of how to represent the factorization types.
This needs tests.