system: use UTC dates and ISO 8601 Z form #29
Conversation
jbenito3
commented
Aug 25, 2015
jbenito3
commented
- Created new database type to store UTC-like dates
- Validated that the date is ISO 8601
- Refactored tests and added extra tests for restful api.
|
@tiborsimko please, pay special attention to the test refactoring I did. Thanks! |
jbenito3
force-pushed
the
6-use-utc-z-dates
branch
10 times, most recently
from
f3fd37c
to
904633a
Compare
|
FYI, https://sqlalchemy-utils.readthedocs.org/en/latest/data_types.html#module-sqlalchemy_utils.types.arrow might be useful as well |
jbenito3
force-pushed
the
6-use-utc-z-dates
branch
from
904633a
to
b6578ad
Compare
|
@tiborsimko now the tests have passed for travis...but they don't in my computer...Shall we merge? |
Why don't we skip the conflicting import statements in from webtest import TestApp # isort:skip
from .base import BaseTest # isort:skipThis should make both local tests and Travis CI happy. |
| @@ -47,10 +53,11 @@ before_install: | |||
| install: | |||
| - travis_retry pip install --upgrade pip | |||
| - travis_retry pip install coveralls | |||
| - travis_retry pip install pytest pytest-pep8 pytest-pep257 pytest-cov pytest-cache pytest-isort | |||
| - travis_retry pip install --upgrade pytest pytest-pep8 pytest-pep257 pytest-cov pytest-cache pytest-isort | |||
| - travis_retry pip install -e . | |||
There was a problem hiding this comment.
The pip --upgrade is perhaps not necessary? (see also my previous isort:skip message)
There was a problem hiding this comment.
Right, I will remove it and I will try isort:skip.
* Stores UTC dates in the dates and validates that follow ISO 8601 Z format. (addresses inveniosoftware#6) Signed-off-by: Jose Benito Gonzalez Lopez <jose.benito.gonzalez@cern.ch>
* Refactores tests in order to share base functionality. (closes inveniosoftware#6) * Uses webtest library to test restful api. Signed-off-by: Jose Benito Gonzalez Lopez <jose.benito.gonzalez@cern.ch>
jbenito3
force-pushed
the
6-use-utc-z-dates
branch
from
b6578ad
to
1b5ebdf
Compare
|
@tiborsimko Thank you for your comments. I have done all the modifications as you suggested. |
