global: added flask app factory #50
Conversation
|
@tiborsimko please could you have a look at the docker modifications I've done before merging...Thanks! |
| @@ -45,6 +47,7 @@ ADD . /code | |||
|
|
|||
| # Install ClaimStore: | |||
| RUN pip install -e . | |||
| RUN claimstore collect | |||
There was a problem hiding this comment.
Extra white space can be removed.
Let's use |
In the commit log message and in the docs, you can maybe specify the full new command line chain to run? Would be easier for people to upgrade... |
|
I have thought of adding it to the docs, but since we have only docker-compose build && docker-compose up, I did not change it. Should I add it somewhere in particular? |
jbenito3
force-pushed
the
22-add-flask-appfactory
branch
5 times, most recently
from
e25ae39
to
68234ae
Compare
|
@tiborsimko shall we merge? |
| from claimstore.modules.claims.fixtures.claimant import CLAIMANT_CDS_FN, \ | ||
| CLAIMANT_INSPIRE_FN, create_claimant, load_claimant | ||
| from claimstore.modules.claims.fixtures.predicate import create_all_predicates | ||
| from webtest import TestApp # isort: skip |
There was a problem hiding this comment.
s/isort: skip/isort:skip/
BTW I still get warnings locally, the best is perhaps to use the following test_restful_api.py module docstring:
"""claimstore.modules.claims.restful test suite.
isort:skip_file
"""This will switch off isort checking for the whole file.
* Refactors the whole code structure to use Flask-AppFactory. (closes inveniosoftware#22) * Adds command `claimstore` with arguments like `run` (runs the web server), `initdb` (creates the database schema), `populatedb` (inserts all the predicates in the database) and `collect` (collects all the static files from the modules to a single location). * Changes Dockerfile and docker-compose in order to use the newly added commands `claimstore collect` and `claimstore initdb && claimstore populatedb`. Signed-off-by: Jose Benito Gonzalez Lopez <jose.benito.gonzalez@cern.ch>
jbenito3
force-pushed
the
22-add-flask-appfactory
branch
from
68234ae
to
1370431
Compare
(closes global: add flask_appfactory #22)
commands
claimstore collect(collects static files) andclaimstore initdb && claimstore populatedbwhich creates the database squema andpopulates it with basic information (predicates).
Signed-off-by: Jose Benito Gonzalez Lopez jose.benito.gonzalez@cern.ch