This repository has been archived by the owner on Feb 17, 2022. It is now read-only.
api: add transitive search #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbenito3
force-pushed
the
49-transitive-relations
branch
from
ead9b84
to
b0a783c
Compare
| @classmethod | ||
| def equivalents(cls, type_name, value): | ||
| """Get claims with the all the equivalent subjects or objects.""" | ||
| all_eq_ids = EquivalentIdentifier.equivalent_ids(type_name, value) |
There was a problem hiding this comment.
If we introduce an eqid concept, let's change all occurrences of eq_id to eqid for greater consistency?
jbenito3
force-pushed
the
49-transitive-relations
branch
2 times, most recently
from
084b246
to
af8fc12
Compare
|
@tiborsimko I have applied all te modifications that you have suggested. I have also taken the time to add 2 extra commands:
|
|
Nice and useful addition with the BTW, since we use But we can take another issue to think about new nice and clean CLI option tree... |
jbenito3
force-pushed
the
49-transitive-relations
branch
from
af8fc12
to
fd28daa
Compare
|
@tiborsimko I liked your proposal and I have just done it. |
jbenito3
force-pushed
the
49-transitive-relations
branch
from
fd28daa
to
dbe9012
Compare
* Adds an extra Model that keeps track of all the equivalent IDs. (closes inveniosoftware#49) * Enables transitive queries to fetch all the related claims (through `/claims?type=xxx&value=yyy&recurse=1`. * Adds a new API resource `/eqids` to list all the equivalent IDs (one can also filter by a specific id using the argument `eqid=`). * Adds command `claimstore index` in order to do operations with indeces. For instance: `claimstore index clear_eqids` and `claimstore index rebuild_eqids`. Signed-off-by: Jose Benito Gonzalez Lopez <jose.benito.gonzalez@cern.ch>
jbenito3
force-pushed
the
49-transitive-relations
branch
from
dbe9012
to
ad1195d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(closes api: optional recursion of transitive relations #49)
/claims?type=xxx&value=yyy&recurse=1./eqidsto list all the equivalent IDs (one can alsofilter by a specific id using the argument
eqid=).Signed-off-by: Jose Benito Gonzalez Lopez jose.benito.gonzalez@cern.ch