Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

travis: add testing matrix #43

Merged
merged 2 commits into from May 17, 2018
Merged

travis: add testing matrix #43

merged 2 commits into from May 17, 2018

Conversation

slint
Copy link
Member

@slint slint commented May 16, 2018

No description provided.

@slint slint force-pushed the travis branch 3 times, most recently from 624f18d to 31b3292 Compare May 16, 2018 14:00

npm update && npm install --silent -g node-sass@3.8.0 clean-css@3.4.19 uglify-js@2.7.3 requirejs@2.2.0

CWD=`pwd`
invenio npm
cd ${VIRTUAL_ENV}/var/instance/static
python_prefix=$(python -c "import sys; print(sys.prefix)")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this going to work when executed inside Docker/OpenShift?

Copy link
Member Author

@slint slint May 16, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I added this because of Docker (and having VIRTUAL_ENV set, basically means that you have a different python prefix already). On OpenShift it would actually fail, since the directory that holds the static files is defined by the environment variable INVENIO_INSTANCE_PATH.

The real problem is that npm install should be running as part of the application with something like invenio npm install and pynpm, so that current_app.static_folder can be used.

@slint slint force-pushed the travis branch 2 times, most recently from 148c4af to 2504c64 Compare May 16, 2018 17:03

check-manifest -u || true

./run-tests.sh
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we, instead of manually installing Elasticsearch, just do scripts/setup and bring all the services needed for Invenio up? It will take good care of spawning the right DB and ES versions plus the rest of the services. Once we need Redis, RabbitMQ... we will have to do the same "manual" installation.

We are doing something similar for OpenData, see here, using our docker-compose environment to test.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed IRL we do it in a different PR, issue #45.

@diegodelemos diegodelemos removed their assignment May 17, 2018
@slint slint merged commit 3779fc6 into inveniosoftware:master May 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants