Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

diff: initial Numpy support #74

Merged
merged 2 commits into from Jun 21, 2016
Merged

Conversation

jirikuncar
Copy link
Member

Signed-off-by: Jiri Kuncar jiri.kuncar@cern.ch

* NEW Adds support for comparing NumPy arrays.  (closes inveniosoftware#68)

Signed-off-by: Jiri Kuncar <jiri.kuncar@cern.ch>
@jirikuncar jirikuncar added this to the v0.6.0 milestone Jun 20, 2016
@coveralls
Copy link

coveralls commented Jun 20, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling cf37e3d on jirikuncar:68-np into e637f35 on inveniosoftware:master.

Signed-off-by: Jiri Kuncar <jiri.kuncar@cern.ch>
@coveralls
Copy link

coveralls commented Jun 20, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling f1815ba on jirikuncar:68-np into e637f35 on inveniosoftware:master.

@kaplun
Copy link
Member

kaplun commented Jun 20, 2016

@mihaibivol you might want to have a look as well, albeit I guess it should have no impact on jsonmerger

@mihaibivol
Copy link
Collaborator

mihaibivol commented Jun 21, 2016

@kaplun For my use-case it's alright. We don't use LIST_TYPES at all in our calls to dictdiffer

@tiborsimko tiborsimko merged commit f1815ba into inveniosoftware:master Jun 21, 2016
@jirikuncar jirikuncar deleted the 68-np branch June 21, 2016 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dictdiffer breaks if dict contains numpy arrays
6 participants